redesign, refactor property filters #2311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljeub-pometry
requested changes
Oct 6, 2025
Collaborator
ljeub-pometry
left a comment
ljeub-pometry
left a comment
There was a problem hiding this comment.
Need to tidy up validation and python builders
python/tests/test_base_install/test_graphql/test_filters/test_nodes_property_filter.py
Outdated
Show resolved
Hide resolved
ljeub-pometry
requested changes
Nov 5, 2025
| operator: node.operator.into(), | ||
| field_name, | ||
| field_value, | ||
| operator, |
Collaborator
There was a problem hiding this comment.
not for now, but the GraphQL side structure is nicer than the internal rust representation, maybe we can change that in the future
* impl nodes select filtering in gql * change semantics of filters in gql, add missing filter apis in edges, fix all tests * add more edge filter tests * add filtering to path from node, add tests * fix apply views * rename filter-iter to select * add select as args * impl window filter (#2359) * impl window filter * impl window filter in python, add tests * impl gql window filter, add tests * ref * impl review suggestions * fixes * fix py and gql * add review suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor /Redesign property filtering