-
Notifications
You must be signed in to change notification settings - Fork 65
James/vectors #2363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
James/vectors #2363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'GraphQL Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: dbfe0e7 | Previous: 675dfd2 | Ratio |
|---|---|---|---|
addNode |
0 req/s |
1314 req/s |
+∞ |
This comment was automatically generated by workflow using github-action-benchmark.
ricopinazo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good overall, I like the vectorisation page, just left a few comments that might be worth addressing now since they refer to things that are not going to change in a foreseeable future
ricopinazo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What changes were proposed in this pull request?
It looks like some things have been renamed or reworked in the https://github.com/Pometry/Raphtory/pull/2249/files PR so any feedback to align these would be helpful