fix: Add isDevBuild() util and namespace mock node dir per instance (#1177)

1. Add isDevBuild() utility to env.ts to separate dev/prod feature gates from ASAR packaging checks
  2. Replace !app.isPackaged dev/prod checks across with isDevBuild()
  3. Namespace the mock node symlink dir per instance (/tmp/agent-node-dev vs /tmp/agent-node-prod) to avoid cross-contamination between simultaneous dev and prod builds
  4. Leave app.isPackaged in place for the 4 sites that genuinely need ASAR .unpacked path resolution

Author: charlesvien

apps/code/src/main/menu.ts

@@ -13,6 +13,7 @@ import { MAIN_TOKENS } from "./di/tokens.js";
 import type { AgentService } from "./services/agent/service.js";
 import type { UIService } from "./services/ui/service.js";
 import type { UpdatesService } from "./services/updates/service.js";
+import { isDevBuild } from "./utils/env.js";
 import { getLogFilePath } from "./utils/logger.js";
 
 function getSystemInfo(): string {
@@ -68,7 +69,7 @@ function buildAppMenu(): MenuItemConstructorOptions {
         },
       },
       { type: "separator" },
-      ...(app.isPackaged
+      ...(!isDevBuild()
         ? [
             {
               label: "Check for Updates...",

apps/code/src/main/services/agent/service.ts

@@ -26,6 +26,7 @@ import type { AcpMessage } from "@shared/types/session-events.js";
 import { app } from "electron";
 import { inject, injectable, preDestroy } from "inversify";
 import { MAIN_TOKENS } from "../../di/tokens.js";
+import { isDevBuild } from "../../utils/env.js";
 import { logger } from "../../utils/logger.js";
 import { TypedEventEmitter } from "../../utils/typed-event-emitter.js";
 import type { FsService } from "../fs/service.js";
@@ -47,9 +48,14 @@ export type { InterruptReason };
 
 const log = logger.scope("agent-service");
 
-const SHARED_MOCK_NODE_DIR = join(tmpdir(), "agent-node-shared");
+const MOCK_NODE_DIR_PREFIX = "agent-node";
 
-/** Mark all content blocks as hidden so the renderer doesn't show a duplicate user message on retry. */
+function getMockNodeDir(): string {
+  const suffix = isDevBuild() ? "dev" : "prod";
+  return join(tmpdir(), `${MOCK_NODE_DIR_PREFIX}-${suffix}`);
+}
+
+/** Mark all content blocks as hidden so the renderer doesn't show a duplicate user message on retry */
 function hidePromptBlocks(prompt: ContentBlock[]): ContentBlock[] {
   return prompt.map((block) => {
     const existing = (
@@ -607,7 +613,7 @@ export class AgentService extends TypedEventEmitter<AgentServiceEvents> {
       },
       skipLogPersistence: isPreview,
       localCachePath: join(app.getPath("home"), ".posthog-code"),
-      debug: !app.isPackaged,
+      debug: isDevBuild(),
       onLog: onAgentLog,
     });
 
@@ -1146,10 +1152,11 @@ For git operations while detached:
   }
 
   private setupMockNodeEnvironment(): string {
+    const mockNodeDir = getMockNodeDir();
     if (!this.mockNodeReady) {
       try {
-        mkdirSync(SHARED_MOCK_NODE_DIR, { recursive: true });
-        const nodeSymlinkPath = join(SHARED_MOCK_NODE_DIR, "node");
+        mkdirSync(mockNodeDir, { recursive: true });
+        const nodeSymlinkPath = join(mockNodeDir, "node");
         try {
           symlinkSync(process.execPath, nodeSymlinkPath);
         } catch (err) {
@@ -1166,7 +1173,7 @@ For git operations while detached:
         log.warn("Failed to setup mock node environment", err);
       }
     }
-    return SHARED_MOCK_NODE_DIR;
+    return mockNodeDir;
   }
 
   private async cleanupSession(taskRunId: string): Promise<void> {

apps/code/src/main/services/posthog-plugin/service.ts

@@ -4,6 +4,7 @@ import { homedir, tmpdir } from "node:os";
 import { join } from "node:path";
 import { app, net } from "electron";
 import { injectable, postConstruct, preDestroy } from "inversify";
+import { isDevBuild } from "../../utils/env.js";
 import { logger } from "../../utils/logger.js";
 import { TypedEventEmitter } from "../../utils/typed-event-emitter.js";
 import { captureException } from "../posthog-analytics.js";
@@ -93,7 +94,7 @@ export class PosthogPluginService extends TypedEventEmitter<PosthogPluginEvents>
    * - Fallback: bundled plugin path.
    */
   getPluginPath(): string {
-    if (!app.isPackaged) {
+    if (isDevBuild()) {
       return this.bundledPluginDir;
     }
 

apps/code/src/main/services/settingsStore.ts

@@ -4,20 +4,21 @@ import * as path from "node:path";
 import { LEGACY_DATA_DIRS, WORKTREES_DIR } from "@shared/constants";
 import { app } from "electron";
 import Store from "electron-store";
+import { isDevBuild } from "../utils/env.js";
 
 interface SettingsSchema {
   worktreeLocation: string;
   preventSleepWhileRunning: boolean;
 }
 
 function getDefaultWorktreeLocation(): string {
-  const isDev = !app.isPackaged;
+  const isDev = isDevBuild();
   const dir = isDev ? `${WORKTREES_DIR}-dev` : WORKTREES_DIR;
   return path.join(os.homedir(), dir);
 }
 
 function getLegacyWorktreeLocations(): string[] {
-  const isDev = !app.isPackaged;
+  const isDev = isDevBuild();
   const locations: string[] = [];
   for (const dir of LEGACY_DATA_DIRS) {
     if (isDev) {

apps/code/src/main/services/updates/service.ts

@@ -1,6 +1,7 @@
 import { app, autoUpdater } from "electron";
 import { inject, injectable, postConstruct, preDestroy } from "inversify";
 import { MAIN_TOKENS } from "../../di/tokens.js";
+import { isDevBuild } from "../../utils/env.js";
 import { logger } from "../../utils/logger.js";
 import { TypedEventEmitter } from "../../utils/typed-event-emitter.js";
 import type { AppLifecycleService } from "../app-lifecycle/service.js";
@@ -43,7 +44,7 @@ export class UpdatesService extends TypedEventEmitter<UpdatesEvents> {
 
   get isEnabled(): boolean {
     return (
-      app.isPackaged &&
+      !isDevBuild() &&
       !process.env[UpdatesService.DISABLE_ENV_FLAG] &&
       UpdatesService.SUPPORTED_PLATFORMS.includes(process.platform)
     );
@@ -63,7 +64,7 @@ export class UpdatesService extends TypedEventEmitter<UpdatesEvents> {
         !UpdatesService.SUPPORTED_PLATFORMS.includes(process.platform)
       ) {
         log.info("Auto updates only supported on macOS and Windows");
-      } else if (!app.isPackaged) {
+      } else if (isDevBuild()) {
         log.info("Auto updates only available in packaged builds");
       }
       return;
@@ -79,7 +80,7 @@ export class UpdatesService extends TypedEventEmitter<UpdatesEvents> {
 
   checkForUpdates(source: CheckSource = "user"): CheckForUpdatesOutput {
     if (!this.isEnabled) {
-      const reason = !app.isPackaged
+      const reason = isDevBuild()
         ? "Updates only available in packaged builds"
         : "Auto updates only supported on macOS and Windows";
       return { success: false, errorMessage: reason, errorCode: "disabled" };

apps/code/src/main/utils/env.ts

@@ -2,6 +2,15 @@ import { mkdirSync } from "node:fs";
 import path from "node:path";
 import { app } from "electron";
 
+/**
+ * Whether this is a development build (running via electron-forge start).
+ * Use this for dev/prod feature gates. Use `app.isPackaged` directly only
+ * when you need to know about ASAR packaging (e.g. resolving .unpacked paths).
+ */
+export function isDevBuild(): boolean {
+  return !app.isPackaged;
+}
+
 export function ensureClaudeConfigDir(): void {
   const existing = process.env.CLAUDE_CONFIG_DIR;
   if (existing) return;

apps/code/src/main/window.ts

@@ -1,10 +1,11 @@
 import path from "node:path";
 import { fileURLToPath } from "node:url";
 import { createIPCHandler } from "@posthog/electron-trpc/main";
-import { app, BrowserWindow, screen, shell } from "electron";
+import { BrowserWindow, screen, shell } from "electron";
 import { buildApplicationMenu } from "./menu.js";
 import { setMainWindowGetter } from "./trpc/context.js";
 import { trpcRouter } from "./trpc/router.js";
+import { isDevBuild } from "./utils/env.js";
 import { type WindowStateSchema, windowStateStore } from "./utils/store.js";
 
 declare const MAIN_WINDOW_VITE_DEV_SERVER_URL: string | undefined;
@@ -85,7 +86,7 @@ function setupExternalLinkHandlers(window: BrowserWindow): void {
 }
 
 export function createWindow(): void {
-  const isDev = !app.isPackaged;
+  const isDev = isDevBuild();
   const savedState = getSavedWindowState();
   let saveTimeout: ReturnType<typeof setTimeout> | null = null;