Set correct arm64v8 info for mariner2 #798
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@harryzcy I'll review this week |
Member
|
@anamnavi make sure @StevenBucher98 reviews the distribution change before we make it. We might want to leave those alone until Azure Linux 3 |
harryzcy
force-pushed
the
mariner2-arm64-v8
branch
from
7e3f5a0 to
c8d46b9
Compare
Contributor
Author
|
@anamnavi @TravisEz13 Hi, is there any updates to this? I think it's a relatively straightforward change. I just rebased on top of current master, and I've also made the same change for Azure Linux 3 |
Contributor
Author
|
Closing as it's not maintained. #797 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Arm64 should be
v8instead ofv7. From wiki: "It was first introduced with the Armv8-A architecture"PR Checklist
Dockerfile,.sh,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.