Skip to content

Conversation

@jdevalk
Copy link
Member

@jdevalk jdevalk commented Nov 13, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

Test on Playground
Test this pull request on the Playground
or download the zip

@jdevalk
Copy link
Member Author

jdevalk commented Nov 13, 2025

Please give the translations a good test too, as I removed the load_plugin_textdomain call.

@ilicfilip
Copy link
Contributor

For me translations are not working with or without the load_plugin_textdomain call.

Reason is that text domain is defined as comment-hacks, but that doesn't match the plugin slug which is yoast-comment-hacks. So the translations are downloaded from .org repo, but because of the mismatch they are not used. When I change search & replace text domain in the PHP files they are loaded fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants