fixup for tests

Signed-off-by: Neil South <neil.south@answerdigital.com>

Author: neildsouth

src/WorkflowManager/WorkflowExecuter/Services/WorkflowExecuterService.cs

@@ -252,13 +252,15 @@ private async Task ProcessArtifactReceivedOutputs(ArtifactsReceivedEvent message
         {
 
             var artifactsInStorage = (await _storageService.VerifyObjectsExistAsync(workflowInstance.BucketId, message.Artifacts.Select(a => a.Path).ToList(), default)) ?? new Dictionary<string, bool>();
-            var messageArtifactsInStorage = message.Artifacts.Where(m => artifactsInStorage.First(a => a.Key == m.Path).Value).ToList();
-
-            var validArtifacts = new Dictionary<string, string>();
-            messageArtifactsInStorage.ForEach(m => validArtifacts.Add(task.Artifacts.Output.First(t => t.Type == m.Type).Name, m.Path));
+            if (artifactsInStorage.Any())
+            {
+                var messageArtifactsInStorage = message.Artifacts.Where(m => artifactsInStorage.First(a => a.Key == m.Path).Value).ToList();
 
-            await _workflowInstanceRepository.UpdateTaskOutputArtifactsAsync(workflowInstance.Id, taskId, validArtifacts);
+                var validArtifacts = new Dictionary<string, string>();
+                messageArtifactsInStorage.ForEach(m => validArtifacts.Add(task.Artifacts.Output.First(t => t.Type == m.Type).Name, m.Path));
 
+                await _workflowInstanceRepository.UpdateTaskOutputArtifactsAsync(workflowInstance.Id, taskId, validArtifacts);
+            }
         }
 
         private async Task<bool> AllRequiredArtifactsReceivedAsync(ArtifactsReceivedEvent message, WorkflowInstance workflowInstance,

tests/UnitTests/WorkflowExecuter.Tests/Services/WorkflowExecuterServiceTests.cs

@@ -3164,11 +3164,12 @@ public async Task ArtifactReceveid_Valid_ReturnesTrue()
         [Fact]
         public async Task ProcessArtifactReceived_Calls_WorkflowInstanceRepository_UpdateTaskOutputArtifactsAsync()
         {
+            var artifactPath = "some path here";
             //incoming artifacts
             var message = new ArtifactsReceivedEvent
             {
                 WorkflowInstanceId = "123", TaskId = "456",
-                Artifacts = new List<Messaging.Common.Artifact>() { new Messaging.Common.Artifact() { Type = ArtifactType.CT, Path = "some path here" } }
+                Artifacts = new List<Messaging.Common.Artifact>() { new Messaging.Common.Artifact() { Type = ArtifactType.CT, Path = artifactPath } }
             };
             var workflowInstance = new WorkflowInstance
             {
@@ -3187,6 +3188,8 @@ public async Task ProcessArtifactReceived_Calls_WorkflowInstanceRepository_Updat
             _workflowRepository.Setup(w => w.GetByWorkflowIdAsync("789"))!
                 .ReturnsAsync(workflowTemplate);
 
+            _storageService.Setup(s => s.VerifyObjectsExistAsync(It.IsAny<string>(), It.IsAny<List<string>>(), It.IsAny<CancellationToken>())).ReturnsAsync(new Dictionary<string, bool> { { artifactPath, true } });
+
             //previously received artifacts
             _artifactReceivedRepository.Setup(r => r.GetAllAsync(workflowInstance.WorkflowId, taskTemplate.Id))
                 .ReturnsAsync((List<ArtifactReceivedItems>?)null);