fixing sonarcloud gripes

neildsouth · neildsouth · commit c4cea6b74d61 · 2023-11-03T12:40:25.000Z
Signed-off-by: Neil South &lt;neil.south@answerdigital.com&gt;
diff --git a/src/WorkflowManager/WorkflowExecuter/Services/WorkflowExecuterService.cs b/src/WorkflowManager/WorkflowExecuter/Services/WorkflowExecuterService.cs
@@ -270,7 +270,7 @@ private async Task ProcessArtifactReceivedOutputs(ArtifactsReceivedEvent message
                 }
             }
 
-            var currentTask = workflowInstance.Tasks?.FirstOrDefault(t => t.TaskId == taskId);
+            var currentTask = workflowInstance.Tasks?.Find(t => t.TaskId == taskId);
 
             currentTask!.OutputArtifacts = validArtifacts; // added here are the parent function saves the object !
 
@@ -686,7 +686,7 @@ private async Task<bool> HandleOutputArtifacts(WorkflowInstance workflowInstance
                 return false;
             }
 
-            var currentTask = workflowInstance.Tasks?.FirstOrDefault(t => t.TaskId == task.TaskId);
+            var currentTask = workflowInstance.Tasks?.Find(t => t.TaskId == task.TaskId);
 
             if (currentTask is not null)
             {

Original file line number	Diff line number	Diff line change
`@@ -270,7 +270,7 @@ private async Task ProcessArtifactReceivedOutputs(ArtifactsReceivedEvent message`
`270`	`270`	`}`
`271`	`271`	`}`
`272`	`272`
`273`		`- var currentTask = workflowInstance.Tasks?.FirstOrDefault(t => t.TaskId == taskId);`
	`273`	`+ var currentTask = workflowInstance.Tasks?.Find(t => t.TaskId == taskId);`
`274`	`274`
`275`	`275`	`currentTask!.OutputArtifacts = validArtifacts; // added here are the parent function saves the object !`
`276`	`276`
`@@ -686,7 +686,7 @@ private async Task<bool> HandleOutputArtifacts(WorkflowInstance workflowInstance`
`686`	`686`	`return false;`
`687`	`687`	`}`
`688`	`688`
`689`		`- var currentTask = workflowInstance.Tasks?.FirstOrDefault(t => t.TaskId == task.TaskId);`
	`689`	`+ var currentTask = workflowInstance.Tasks?.Find(t => t.TaskId == task.TaskId);`
`690`	`690`
`691`	`691`	`if (currentTask is not null)`
`692`	`692`	`{`