Skip to content

shortening s3 policy #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 31, 2023
Merged

shortening s3 policy #904

merged 4 commits into from
Oct 31, 2023

Conversation

@neildsouth
Copy link
Member

@neildsouth neildsouth commented Oct 31, 2023

Description

Fixes # .

making s3 policy < 2048 limit

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@neildsouth
shortening s3 policy
ac7af0d 
Signed-off-by: Neil South <neil.south@answerdigital.com>
@neildsouth
fix typo
1b0fcce 
Signed-off-by: Neil South <neil.south@answerdigital.com>
@neildsouth
merge in#
fbdebe2 
Signed-off-by: Neil South <neil.south@answerdigital.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

89.5% 89.5% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@neildsouth
fixing up paths
82042a3 
Signed-off-by: Neil South <neil.south@answerdigital.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

77.3% 77.3% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@neildsouth neildsouth merged commit b4e3a47 into develop Oct 31, 2023
@neildsouth neildsouth deleted the AI-230 branch October 31, 2023 16:57
@mocsharp mocsharp modified the milestones: 0.1.30, 0.2.0 Jun 6, 2024
@mocsharp mocsharp added the enhancement New feature or request label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DanielNuttall-AD DanielNuttall-AD DanielNuttall-AD approved these changes

@lillie-dae lillie-dae lillie-dae approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

0.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@neildsouth @DanielNuttall-AD @lillie-dae @mocsharp