AMS revisions #89
Merged
AMS revisions #89
+96
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
Collaborator
Author
|
I did skim through all of the notebooks in the preview and they look good as well as the build. |
jukent
approved these changes
Jan 11, 2025
Collaborator
jukent
left a comment
jukent
left a comment
There was a problem hiding this comment.
Oh gosh thanks for finding all these typos and overall grammar corrections!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily editorial updates to the notebooks, but also swaps the BinderHub links back to the Pythia BinderHub following today's discussion and adds a JupyterLab MyST extension so that the admonitions render (this then required changing some image specification syntax in the notebooks).
I can also split this into multiple PRs if helpful or I think we can just leave things as is and workaround if that's more comfortable at this point too. We'll probably just want to provide a link for the hub we want and will have to live with a few typos.