Conversation
and small stylistic changes
and fix bug for dd.global_time = 0.0
|
Looks like it works I did some minor bug fixes and made the naming more uniform with the rest of the code base This is now the API: using GACODE
input_gacode = GACODE.InputGACODE(dd)
GACODE.save(ip,"<your filename>")
input_gacode = GACODE.load("<your filename>") |
…l into input_gacode
@orso82 adding in D and T seperate to input_gacode is probably vital for other people to use it I can't come up with an elegant way to do this can you come up with one? I strongly remember it was your decision to put them lumped :P
|
@orso82 or @bclyons12 it looks like I don't have merge rights on this repo can either of you merge this? |
|
I still don't understand why one would need the special handling of DT in input.gacode If the dd has a single hydrogenic ion with mass of 2.5 then that's what should also go in the input.gacode that is derived from dd |
|
Are there IMAS functions to bundle and unbundle DT? |
|
@bclyons12 I wish we did not yet merge this, since I don't believe this is the right way of handling DT. The Instead, I see the ability to modify the ion species (like split To answer @jmcclena question, IMAS.jl has a |
|
@orso82 There was no release made, so it should be simple to revert this if desired. |
This pull request adds reading and writing of input.gacode files.
Example reading and writing an input.gacode file: