-
Notifications
You must be signed in to change notification settings - Fork 905
Link explicitly with libpython under Cygwin #5571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I don't know why the CI is failing. I used towncrier to create a news entry. |
Member
|
Thanks, |
davidhewitt
reviewed
Oct 29, 2025
6a9c6db to
3f85c35
Compare
LilyFirefly
approved these changes
Oct 30, 2025
davidhewitt
reviewed
Oct 31, 2025
davidhewitt
approved these changes
Nov 1, 2025
Member
|
merge from |
As with native Windows Python, we need to explicitly link with libpython under Cygwin too. This fixes building extensions under Cygwin.
0.13.3 added support for Cygwin
Contributor
Author
|
Thanks! |
davidhewitt
pushed a commit
that referenced
this pull request
Nov 23, 2025
* Link explicitly with libpython under Cygwin As with native Windows Python, we need to explicitly link with libpython under Cygwin too. This fixes building extensions under Cygwin. * bump `target-lexicon` to 0.13.3 0.13.3 added support for Cygwin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with native Windows Python, we need to explicitly link with libpython under Cygwin too.
This fixes building extensions under Cygwin.
Fixes #5463