Skip to content

Conversation

@lazka
Copy link
Contributor

@lazka lazka commented Oct 29, 2025

As with native Windows Python, we need to explicitly link with libpython under Cygwin too.

This fixes building extensions under Cygwin.

Fixes #5463

@lazka
Copy link
Contributor Author

lazka commented Oct 29, 2025

I don't know why the CI is failing. I used towncrier to create a news entry.

@davidhewitt
Copy link
Member

Thanks, fmt job probably broken by fixes in rumdl, we can fix that separately and then return here

@lazka lazka force-pushed the cygwin-link branch 3 times, most recently from 6a9c6db to 3f85c35 Compare October 30, 2025 08:05
@bschoenmaeckers bschoenmaeckers added this pull request to the merge queue Oct 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 31, 2025
@bschoenmaeckers bschoenmaeckers added this pull request to the merge queue Oct 31, 2025
@bschoenmaeckers bschoenmaeckers removed this pull request from the merge queue due to a manual request Oct 31, 2025
@davidhewitt davidhewitt added this pull request to the merge queue Oct 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 31, 2025
@davidhewitt
Copy link
Member

merge from main should fix the tests (from Rust 1.91 changes)

lazka added 2 commits November 1, 2025 18:07
As with native Windows Python, we need to explicitly link with
libpython under Cygwin too.

This fixes building extensions under Cygwin.
0.13.3 added support for Cygwin
@davidhewitt davidhewitt enabled auto-merge November 1, 2025 17:09
@davidhewitt davidhewitt added this pull request to the merge queue Nov 1, 2025
Merged via the queue into PyO3:main with commit 30a0209 Nov 1, 2025
43 checks passed
@lazka
Copy link
Contributor Author

lazka commented Nov 1, 2025

Thanks!

davidhewitt pushed a commit that referenced this pull request Nov 23, 2025
* Link explicitly with libpython under Cygwin

As with native Windows Python, we need to explicitly link with
libpython under Cygwin too.

This fixes building extensions under Cygwin.

* bump `target-lexicon` to 0.13.3

0.13.3 added support for Cygwin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support cygwin

3 participants