Fix memory leak and update valgrind suppression file (#365)

* pyslurm.JobStep: fix small memory leak

slurm_free_job_step_info_members does not free "submit_line", leading to
a memory leak, so we free it manually.
Reported to SchedMD: https://support.schedmd.com/show_bug.cgi?id=21729

* Update valgrind suppression file

* job live stats: fix uninitialized value errors in valgrind

Author: tazend

pyslurm/core/job/stats.pyx

@@ -70,6 +70,7 @@ cdef load_single(JobStep step):
         else:
             verify_rpc(rc)
 
+    memset(&locks, 0, sizeof(assoc_mgr_lock_t))
     memset(&db_step, 0, sizeof(slurmdb_step_rec_t))
     memset(&db_step.stats, 0, sizeof(slurmdb_stats_t))
 

pyslurm/core/job/step.pyx

@@ -190,6 +190,9 @@ cdef class JobStep:
 
     def _dealloc_impl(self):
         slurm_free_job_step_info_members(self.ptr)
+        # Bug in slurm_free_job_step_info_members - submit_line is not freed
+        # there.
+        xfree(self.ptr.submit_line)
         xfree(self.ptr)
         slurm_free_update_step_msg(self.umsg)
         self.umsg = NULL

valgrind-pyslurm.supp

@@ -33,6 +33,15 @@
    ...
 }
 
+{
+   Slurm topology_g_init
+   Memcheck:Leak
+   match-leak-kinds: possible
+   ...
+   fun:topology_g_init
+   ...
+}
+
 {
    Slurm slurm_auth_init
    Memcheck:Leak
@@ -43,11 +52,19 @@
 }
 
 {
-   Slurm slurm_conf_init/slurm_init
+   Slurm slurm_conf_init
    Memcheck:Leak
    match-leak-kinds: possible
    ...
    fun:slurm_conf_init
+   ...
+}
+
+{
+   Slurm slurm_init
+   Memcheck:Leak
+   match-leak-kinds: possible
+   ...
    fun:slurm_init
    ...
 }