ExtendedSigningKey from hd wallet: use key type from class

Author: gszabo

pycardano/key.py

@@ -211,8 +211,8 @@ def from_hdwallet(cls, hdwallet: HDWallet) -> ExtendedSigningKey:
 
         return cls(
             payload=hdwallet.xprivate_key + hdwallet.public_key + hdwallet.chain_code,
-            key_type="PaymentExtendedSigningKeyShelley_ed25519_bip32",
-            description="Payment Signing Key",
+            key_type=cls.KEY_TYPE,
+            description=cls.DESCRIPTION,
         )
 
 

test/pycardano/test_key.py

@@ -1,12 +1,17 @@
 import pathlib
 import tempfile
 
+from mnemonic import Mnemonic
+
+from pycardano import HDWallet
 from pycardano.key import (
     ExtendedSigningKey,
     ExtendedVerificationKey,
+    PaymentExtendedSigningKey,
     PaymentKeyPair,
     PaymentSigningKey,
     PaymentVerificationKey,
+    StakeExtendedSigningKey,
     StakePoolKeyPair,
     StakePoolSigningKey,
     StakePoolVerificationKey,
@@ -191,3 +196,15 @@ def test_stake_pool_key_hash():
 
     assert len(sk_set) == 1
     assert len(vk_set) == 1
+
+
+def test_extended_signing_key_from_hd_wallet_uses_type_and_description_from_class():
+    hd_wallet = HDWallet.from_mnemonic(Mnemonic().generate())
+
+    extended_payment_key = PaymentExtendedSigningKey.from_hdwallet(hd_wallet)
+    assert extended_payment_key.key_type == PaymentExtendedSigningKey.KEY_TYPE
+    assert extended_payment_key.description == PaymentExtendedSigningKey.DESCRIPTION
+
+    extended_stake_key = StakeExtendedSigningKey.from_hdwallet(hd_wallet)
+    assert extended_stake_key.key_type == StakeExtendedSigningKey.KEY_TYPE
+    assert extended_stake_key.description == StakeExtendedSigningKey.DESCRIPTION