Fix swapped attributes #28
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex parses something like `001-LEC (1234)` which makes sense to be
of the format `{class_num}-{type} ({solus_id})`
`class_num` and `solud_id` were previously swapped which is incorrect.
Member
|
This is definitely wrong, but the attributes may be swapped in more than one place (I remember something about this before). Can you do a before/after test to verify that the old behaviour was wrong and the new is correct? If so, then we can just merge this. If this PR switches the attributes to be incorrect, some code somewhere else will need to be changed too. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex parses something like
001-LEC (1234)which makes sense to be of the format{class_num}-{type} ({solus_id})Unless I'm missing something?
The regex is at line 21