Skip to content

Commit e033e8e

Browse files
committed
fix: change to full optimization
1 parent 95a1d72 commit e033e8e

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/query_farm_sql_scan_planning/planner.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -497,7 +497,7 @@ def get_matching_files(
497497
raise ValueError(f"Expected a sqlglot expression, got {type(expression)}")
498498

499499
# Simplify the parsed expression, move all of the literals to the right side
500-
expression = sqlglot.optimizer.simplify.simplify(expression)
500+
expression = sqlglot.optimizer.optimize(expression)
501501

502502
for filename, file_info in self.files:
503503
eval_result = self._evaluate_sql_node(expression, file_info)

src/query_farm_sql_scan_planning/test_planner.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,11 @@ def sample_files() -> list[tuple[str, FileFieldInfo]]:
248248
("v1 * v1 < 200", ALL_FILES),
249249
("200 > v1 * v1", ALL_FILES),
250250
("abs(v1 - 500) < 100", ALL_FILES), # Absolute difference
251-
("v1 < 100 and abs(v1 - 500) < 100", ALL_FILES), # Absolute difference
251+
# Drop abs difference, but should still respect bounds.
252+
(
253+
"v1 < 100 and abs(v1 - 500) < 150",
254+
{"file1"},
255+
),
252256
("v1 % 2 == 0", ALL_FILES), # Even numbers
253257
(
254258
"v1 is not distinct from 5",

0 commit comments

Comments
 (0)