Skip to content

Commit 6a986c0

Browse files
committed
drm/amdkfd: Use a new capability bit for SRAM ECC
Existing, buggy user mode breaks when SRAM ECC is correctly reported as "enabled". To avoid breaking existing user mode, deprecate that bit and leave it as 0. Define a new bit to report the actual SRAM ECC mode that new, correct user mode can use in the future. Fixes: 7ec177b ("drm/amdkfd: fix set kfd node ras properties value") Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
1 parent 9b83380 commit 6a986c0

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/gpu/drm/amd/amdkfd/kfd_topology.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,14 @@
5454
#define HSA_DBG_TRAP_DEBUG_WATCH_MASK_LO_BIT 0x00000004
5555
#define HSA_DBG_TRAP_DEBUG_WATCH_MASK_HI_BIT (29 << 4)
5656

57-
#define HSA_CAP_SRAM_EDCSUPPORTED 0x00080000
57+
#define HSA_CAP_RESERVED_WAS_SRAM_EDCSUPPORTED 0x00080000 /* Old buggy user mode depends on this being 0 */
5858
#define HSA_CAP_MEM_EDCSUPPORTED 0x00100000
5959
#define HSA_CAP_RASEVENTNOTIFY 0x00200000
6060
#define HSA_CAP_ASIC_REVISION_MASK 0x03c00000
6161
#define HSA_CAP_ASIC_REVISION_SHIFT 22
62+
#define HSA_CAP_SRAM_EDCSUPPORTED 0x04000000
6263

63-
#define HSA_CAP_RESERVED 0xfc078000
64+
#define HSA_CAP_RESERVED 0xf80f8000
6465

6566
struct kfd_node_properties {
6667
uint64_t hive_id;

0 commit comments

Comments
 (0)