From 94a4a8f42e0d15248c0947f7ea99ebb05e694799 Mon Sep 17 00:00:00 2001 From: Steve Leung Date: Mon, 7 Jul 2025 10:22:35 -0600 Subject: [PATCH 1/4] CHANGELOG: update for 7.0 --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 010a9f9f4524..8e97615de422 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,7 +3,7 @@ Documentation for hipFFT is available at [https://rocm.docs.amd.com/projects/hipFFT/en/latest/](https://rocm.docs.amd.com/projects/hipFFT/en/latest/). -## hipFFT 1.0.20 (unreleased) +## hipFFT 1.0.20 for ROCm 7.0.0 ### Added From 41286737f11641581532d1997e3322f3fee0a537 Mon Sep 17 00:00:00 2001 From: Alan Ayala Date: Mon, 7 Jul 2025 19:25:14 +0200 Subject: [PATCH 2/4] Prevent double allocation and memory leak in hipfft test --- clients/tests/simple_test.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/clients/tests/simple_test.cpp b/clients/tests/simple_test.cpp index 91ebf423ff77..0168f06f4a54 100644 --- a/clients/tests/simple_test.cpp +++ b/clients/tests/simple_test.cpp @@ -49,9 +49,8 @@ inline double type_epsilon() TEST(hipfftTest, Create1dPlan) { - hipfftHandle plan = hipfft_params::INVALID_PLAN_HANDLE; - ASSERT_EQ(hipfftCreate(&plan), HIPFFT_SUCCESS); - size_t length = 1024; + hipfftHandle plan = hipfft_params::INVALID_PLAN_HANDLE; + size_t length = 1024; ASSERT_EQ(hipfftPlan1d(&plan, length, HIPFFT_C2C, 1), HIPFFT_SUCCESS); ASSERT_EQ(hipfftDestroy(plan), HIPFFT_SUCCESS); From 9817354632a455d448d2c2ecb2789766c01cb444 Mon Sep 17 00:00:00 2001 From: Alan Ayala Date: Tue, 8 Jul 2025 01:13:53 +0200 Subject: [PATCH 3/4] Remove File reorganization backward compatibility --- CMakeLists.txt | 11 ----------- library/CMakeLists.txt | 17 ----------------- 2 files changed, 28 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index cc56f5d0a999..1171632e68b4 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -181,17 +181,6 @@ endif() # Show the actual compiler(internal option) message(STATUS "BUILD_WITH_COMPILER = " ${BUILD_WITH_COMPILER}) -# FOR HANDLING ENABLE/DISABLE OPTIONAL BACKWARD COMPATIBILITY for FILE/FOLDER REORG -option(BUILD_FILE_REORG_BACKWARD_COMPATIBILITY "Build with file/folder reorg with backward compatibility enabled" OFF) -if(BUILD_FILE_REORG_BACKWARD_COMPATIBILITY AND NOT WIN32) - rocm_wrap_header_dir( - ${CMAKE_SOURCE_DIR}/library/include - PATTERNS "*.h" - GUARDS SYMLINK WRAPPER - WRAPPER_LOCATIONS ${CMAKE_INSTALL_INCLUDEDIR} - ) -endif() - # Version set( VERSION_STRING "1.0.20" ) set( hipfft_SOVERSION 0.1 ) diff --git a/library/CMakeLists.txt b/library/CMakeLists.txt index 0e7933dfd012..0aa0a6295217 100644 --- a/library/CMakeLists.txt +++ b/library/CMakeLists.txt @@ -148,14 +148,6 @@ include( GenerateExportHeader ) generate_export_header( hipfft EXPORT_FILE_NAME ${PROJECT_BINARY_DIR}/include/hipfft/hipfft-export.h ) execute_process(COMMAND ${CMAKE_COMMAND} -E copy_directory ${PROJECT_SOURCE_DIR}/library/include ${PROJECT_BINARY_DIR}/include) -if (BUILD_FILE_REORG_BACKWARD_COMPATIBILITY AND NOT WIN32) - rocm_wrap_header_file( - hipfft-version.h hipfft-export.h - GUARDS SYMLINK WRAPPER - WRAPPER_LOCATIONS ${CMAKE_INSTALL_INCLUDEDIR} hipfft/${CMAKE_INSTALL_INCLUDEDIR} - ORIGINAL_FILES ${PROJECT_BINARY_DIR}/include/hipfft/hipfft-version.h - ) -endif( ) if( ROCmCMakeBuildTools_FOUND ) @@ -164,15 +156,6 @@ if( ROCmCMakeBuildTools_FOUND ) ${CMAKE_BINARY_DIR}/include ) - if(BUILD_FILE_REORG_BACKWARD_COMPATIBILITY AND NOT WIN32) - rocm_install( - DIRECTORY - "${PROJECT_BINARY_DIR}/hipfft" - DESTINATION "." ) - message( STATUS "Backward Compatible Sym Link Created for include directories" ) - endif() - - rocm_export_targets( TARGETS hip::hipfft DEPENDS PACKAGE hip STATIC_DEPENDS From 45ff93e15473548a377a7733ce2b750e37ea9c35 Mon Sep 17 00:00:00 2001 From: Alan Ayala Date: Tue, 8 Jul 2025 01:36:09 +0200 Subject: [PATCH 4/4] Update Changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8e97615de422..16512b6b0419 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ Documentation for hipFFT is available at * Removed hipfft-rider legacy compatibility from clients * Remove support for the gfx940 and gfx941 targets from the client programs. +* Remove backward compatibility symlink for include directories. ## hipFFT 1.0.18 for ROCm 6.4.0