Skip to content

Cherry-pick to release/rocm-rel-7.0: Backward compatibility and double allocation fixes, Changelog update #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vamovsik merged 6 commits into from
Aug 6, 2025
Merged

Cherry-pick to release/rocm-rel-7.0: Backward compatibility and double allocation fixes, Changelog update #1005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
94a4a8f
CHANGELOG: update for 7.0
evetsso Jul 7, 2025
4128673
Prevent double allocation and memory leak in hipfft test
af-ayala Jul 7, 2025
9817354
Remove File reorganization backward compatibility
af-ayala Jul 7, 2025
45ff93e
Update Changelog
af-ayala Jul 7, 2025
ab5797c
Merge commit '45ff93e15473548a377a7733ce2b750e37ea9c35' into import/r…
assistant-librarian[bot] Jul 31, 2025
5b6174a
Merge branch 'release/rocm-rel-7.0' into import/release_rocm-rel-7.0/…
af-ayala Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion projects/hipfft/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
Documentation for hipFFT is available at
[https://rocm.docs.amd.com/projects/hipFFT/en/latest/](https://rocm.docs.amd.com/projects/hipFFT/en/latest/).

## hipFFT 1.0.20 (unreleased)
## hipFFT 1.0.20 for ROCm 7.0.0

### Added

Expand All @@ -13,6 +13,7 @@ Documentation for hipFFT is available at

* Removed hipfft-rider legacy compatibility from clients
* Remove support for the gfx940 and gfx941 targets from the client programs.
* Remove backward compatibility symlink for include directories.

## hipFFT 1.0.18 for ROCm 6.4.0

Expand Down
11 changes: 0 additions & 11 deletions projects/hipfft/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,17 +181,6 @@ endif()
# Show the actual compiler(internal option)
message(STATUS "BUILD_WITH_COMPILER = " ${BUILD_WITH_COMPILER})

# FOR HANDLING ENABLE/DISABLE OPTIONAL BACKWARD COMPATIBILITY for FILE/FOLDER REORG
option(BUILD_FILE_REORG_BACKWARD_COMPATIBILITY "Build with file/folder reorg with backward compatibility enabled" OFF)
if(BUILD_FILE_REORG_BACKWARD_COMPATIBILITY AND NOT WIN32)
rocm_wrap_header_dir(
${CMAKE_SOURCE_DIR}/library/include
PATTERNS "*.h"
GUARDS SYMLINK WRAPPER
WRAPPER_LOCATIONS ${CMAKE_INSTALL_INCLUDEDIR}
)
endif()

# Version
set( VERSION_STRING "1.0.20" )
set( hipfft_SOVERSION 0.1 )
Expand Down
5 changes: 2 additions & 3 deletions projects/hipfft/clients/tests/simple_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,8 @@ inline double type_epsilon<double>()

TEST(hipfftTest, Create1dPlan)
{
hipfftHandle plan = hipfft_params::INVALID_PLAN_HANDLE;
ASSERT_EQ(hipfftCreate(&plan), HIPFFT_SUCCESS);
size_t length = 1024;
hipfftHandle plan = hipfft_params::INVALID_PLAN_HANDLE;
size_t length = 1024;
ASSERT_EQ(hipfftPlan1d(&plan, length, HIPFFT_C2C, 1), HIPFFT_SUCCESS);

ASSERT_EQ(hipfftDestroy(plan), HIPFFT_SUCCESS);
Expand Down
17 changes: 0 additions & 17 deletions projects/hipfft/library/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,14 +148,6 @@ include( GenerateExportHeader )
generate_export_header( hipfft EXPORT_FILE_NAME ${PROJECT_BINARY_DIR}/include/hipfft/hipfft-export.h )

execute_process(COMMAND ${CMAKE_COMMAND} -E copy_directory ${PROJECT_SOURCE_DIR}/library/include ${PROJECT_BINARY_DIR}/include)
if (BUILD_FILE_REORG_BACKWARD_COMPATIBILITY AND NOT WIN32)
rocm_wrap_header_file(
hipfft-version.h hipfft-export.h
GUARDS SYMLINK WRAPPER
WRAPPER_LOCATIONS ${CMAKE_INSTALL_INCLUDEDIR} hipfft/${CMAKE_INSTALL_INCLUDEDIR}
ORIGINAL_FILES ${PROJECT_BINARY_DIR}/include/hipfft/hipfft-version.h
)
endif( )

if( ROCmCMakeBuildTools_FOUND )

Expand All @@ -164,15 +156,6 @@ if( ROCmCMakeBuildTools_FOUND )
${CMAKE_BINARY_DIR}/include
)

if(BUILD_FILE_REORG_BACKWARD_COMPATIBILITY AND NOT WIN32)
rocm_install(
DIRECTORY
"${PROJECT_BINARY_DIR}/hipfft"
DESTINATION "." )
message( STATUS "Backward Compatible Sym Link Created for include directories" )
endif()


rocm_export_targets( TARGETS hip::hipfft
DEPENDS PACKAGE hip
STATIC_DEPENDS
Expand Down