Skip to content

Conversation

@Granine
Copy link
Contributor

@Granine Granine commented Oct 8, 2025

What does this add?

Increase mcp required base version from 1.9.0 to 1.16.0. All test and local repo are using 1.16.0 by default so there is no code impact.

The reason of the change is that some features we used only exist >= 1.12, (mcp.os), hence it is worth updating. The reason for bumping directly to 1.16.0 is that all versions of 1.12 and above are backward safe. We wil also enjoy extra feature and supporting starting with latest version

Type of changes

Please check the type of change your PR introduces:

  • [X ] 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update (improvements or corrections to documentation)
  • 🎨 Code style/formatting (changes that do not affect the meaning of the code)
  • ♻️ Refactoring (code change that neither fixes a bug nor adds a feature)
  • ⚡ Performance improvement (code change that improves performance)
  • ✅ Test update (adding missing tests or correcting existing tests)
  • 🔧 Build/CI changes (changes to build process or continuous integration)
  • [X ] 🗑️ Chore (other changes that don't modify src or test files)
    \

Copy link
Collaborator

@soulFood5632 soulFood5632 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Guan

"railtracks",
"watchdog >= 3.0.0"
]
dependencies = ["watchdog >= 3.0.0"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

railtracks removed as dependency?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He's investigating the test failures with circular import structures, I don't think the PRs ready for review yet

@Granine
Copy link
Contributor Author

Granine commented Oct 13, 2025

Finally found out reason why updating mcp version is failing, so currently, new mcp requires nvicorn>1.31.0, while litellm require <1.30, so its not working, however, the feature levi implemented requires item introduced in recent mcp versions so we have a deadlock with no current solutions.

@Granine
Copy link
Contributor Author

Granine commented Oct 13, 2025

Raised issue on litellm: BerriAI/litellm#15511

@soulFood5632
Copy link
Collaborator

@Granine looks like we had a reversion on our originaal fix PR BerriAI/litellm#16300

we will need to address ^

@soulFood5632
Copy link
Collaborator

Looks like we have updation. Thanks @Granine

@Amir-R25
Copy link
Collaborator

Amir-R25 commented Nov 8, 2025

Thanks @Granine, I'll just add this here for tracking: BerriAI/litellm#16307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] MCP not functioning in jupyter notebook due to outdated versioning requirement

5 participants