From d7433cebf22e3cdf865c224d4bbe8acbf4ab03bc Mon Sep 17 00:00:00 2001 From: ZendeAditya Date: Fri, 18 Apr 2025 20:32:33 +0530 Subject: [PATCH 1/2] remove : feature flag & test cases --- .../Components/Tasks/TaskUpdateModal.test.tsx | 38 ------------------- .../taskDetails/TaskUpdateModal.tsx | 22 ++++------- 2 files changed, 8 insertions(+), 52 deletions(-) diff --git a/__tests__/Unit/Components/Tasks/TaskUpdateModal.test.tsx b/__tests__/Unit/Components/Tasks/TaskUpdateModal.test.tsx index 152fe73b0..a7653db00 100644 --- a/__tests__/Unit/Components/Tasks/TaskUpdateModal.test.tsx +++ b/__tests__/Unit/Components/Tasks/TaskUpdateModal.test.tsx @@ -181,42 +181,4 @@ describe('TaskUpdateModal', () => { expect(mockOnUpdateSuccess).toHaveBeenCalled(); expect(mockSetIsOpen).toHaveBeenCalledWith(false); }); - - it('should call the setIsOpen when close button is clicked', async () => { - renderWithRouter( - - - , - { query: { dev: 'true' } } - ); - - const closeButton = screen.getByTestId( - 'task-update-modal-close-button' - ); - - fireEvent.click(closeButton); - expect(mockSetIsOpen).toHaveBeenCalledWith(false); - }); - - it('should show the close button when dev is true', () => { - renderWithRouter(, { - query: { dev: 'true' }, - }); - - const closeButton = screen.getByTestId( - 'task-update-modal-close-button' - ); - expect(closeButton).toBeInTheDocument(); - }); - - it('should not show the close button when dev is false', async () => { - renderWithRouter(, { - query: { dev: 'false' }, - }); - - const closeButton = screen.queryByTestId( - 'task-update-modal-close-button' - ); - expect(closeButton).not.toBeInTheDocument(); - }); }); diff --git a/src/components/taskDetails/TaskUpdateModal.tsx b/src/components/taskDetails/TaskUpdateModal.tsx index 5c2239f8f..947b99d88 100644 --- a/src/components/taskDetails/TaskUpdateModal.tsx +++ b/src/components/taskDetails/TaskUpdateModal.tsx @@ -5,7 +5,6 @@ import getCurrentDate from '@/utils/getLatestDate'; import { questions } from '@/constants/ProgressUpdates'; import ProgressForm from '../ProgressForm/ProgressForm'; import task from '@/interfaces/task.type'; -import { useRouter } from 'next/router'; import { IoMdClose } from 'react-icons/io'; type Props = { isOpen: boolean; @@ -26,22 +25,17 @@ function TaskUpdateModal({ editedTaskDetails, onUpdateSuccess, }: Props) { - const router = useRouter(); - const { dev } = router.query; - return ( setIsOpen(false)}>
- {dev === 'true' && ( - - )} +

Update Progress

Task Updates

From 1912e3b0cc081e5c549cf613c335d26f8f0609ec Mon Sep 17 00:00:00 2001 From: ZendeAditya Date: Sun, 20 Apr 2025 03:45:27 +0530 Subject: [PATCH 2/2] add removed test case --- .../Components/Tasks/TaskUpdateModal.test.tsx | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/__tests__/Unit/Components/Tasks/TaskUpdateModal.test.tsx b/__tests__/Unit/Components/Tasks/TaskUpdateModal.test.tsx index a7653db00..c22ee3a3f 100644 --- a/__tests__/Unit/Components/Tasks/TaskUpdateModal.test.tsx +++ b/__tests__/Unit/Components/Tasks/TaskUpdateModal.test.tsx @@ -181,4 +181,19 @@ describe('TaskUpdateModal', () => { expect(mockOnUpdateSuccess).toHaveBeenCalled(); expect(mockSetIsOpen).toHaveBeenCalledWith(false); }); + it('should call the setIsOpen when close button is clicked', async () => { + renderWithRouter( + + + , + { query: { dev: 'true' } } + ); + + const closeButton = screen.getByTestId( + 'task-update-modal-close-button' + ); + + fireEvent.click(closeButton); + expect(mockSetIsOpen).toHaveBeenCalledWith(false); + }); });