From 955ac75735e5161808bc8cb27e9612e2a72fe512 Mon Sep 17 00:00:00 2001 From: tejaskh3 Date: Sat, 19 Apr 2025 01:37:19 +0530 Subject: [PATCH 1/4] feat: add github workflow for test coverage --- .github/workflows/coverage.yml | 38 ++++++++ ember-cli-build.js | 7 ++ package.json | 3 +- pnpm-lock.yaml | 168 ++++++++++++++++++++++++++++++--- tests/test-helper.js | 9 ++ 5 files changed, 210 insertions(+), 15 deletions(-) create mode 100644 .github/workflows/coverage.yml diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml new file mode 100644 index 000000000..3e85cfd1b --- /dev/null +++ b/.github/workflows/coverage.yml @@ -0,0 +1,38 @@ +name: Test Coverage + +on: + pull_request: + branches: [ main, master, develop ] + +jobs: + coverage: + runs-on: ubuntu-latest + permissions: + contents: read + pull-requests: write + steps: + - uses: actions/checkout@v3 + + - name: Install pnpm + uses: pnpm/action-setup@v2 + with: + version: 8 + run_install: false + + - name: Setup Node.js + uses: actions/setup-node@v3 + with: + node-version: 18 + cache: 'pnpm' + + - name: Install dependencies + run: pnpm install + + - name: Run tests with coverage + run: pnpm run test:coverage || true + + - name: Post coverage comment + uses: romeovs/lcov-reporter-action@v0.3.1 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + lcov-file: ./coverage/lcov.info diff --git a/ember-cli-build.js b/ember-cli-build.js index d4f869c90..b2528aeb4 100644 --- a/ember-cli-build.js +++ b/ember-cli-build.js @@ -12,6 +12,13 @@ module.exports = function (defaults) { 'ember-fetch': { preferNative: true, }, + babel: { + plugins: [ + ...require('ember-cli-code-coverage').buildBabelPlugin({ + embroider: true, + }), + ], + }, }); // Use `app.import` to add additional libraries to the generated diff --git a/package.json b/package.json index 821a006cd..d13471e7c 100644 --- a/package.json +++ b/package.json @@ -27,6 +27,7 @@ "start": "ember serve", "test": "concurrently \"pnpm:lint\" \"pnpm:test:*\" --names \"lint,test:\"", "test:ember": "ember test", + "test:coverage": "COVERAGE=true ember test", "preinstall": "npx only-allow pnpm" }, "dependencies": { @@ -34,7 +35,6 @@ "cropperjs": "^1.5.12", "d3-cloud": "1.2.7", "dotenv": "16.0.2", - "ember-cli-qrcode": "^2.1.0", "ember-cli-fastboot": "4.1.5", "ember-d3": "0.5.1", "ember-phone-input": "^10.0.0", @@ -66,6 +66,7 @@ "ember-cli-babel": "8.2.0", "ember-cli-clean-css": "3.0.0", "ember-cli-clipboard": "1.0.0", + "ember-cli-code-coverage": "^3.1.0", "ember-cli-dependency-checker": "3.3.2", "ember-cli-htmlbars": "6.3.0", "ember-cli-inject-live-reload": "2.1.0", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index a3a1a685c..25b6fdec6 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -26,9 +26,6 @@ importers: ember-cli-fastboot: specifier: 4.1.5 version: 4.1.5(ember-source@5.9.0(@babel/core@7.24.7)(@glimmer/component@1.1.2(@babel/core@7.24.7))(rsvp@4.8.5)(webpack@5.91.0)) - ember-cli-qrcode: - specifier: ^2.1.0 - version: 2.1.0 ember-d3: specifier: 0.5.1 version: 0.5.1 @@ -114,6 +111,9 @@ importers: ember-cli-clipboard: specifier: 1.0.0 version: 1.0.0(@babel/core@7.24.7)(webpack@5.91.0) + ember-cli-code-coverage: + specifier: ^3.1.0 + version: 3.1.0(@embroider/compat@3.8.0(@embroider/core@3.5.0))(@embroider/core@3.5.0) ember-cli-dependency-checker: specifier: 3.3.2 version: 3.3.2(ember-cli@5.9.0(handlebars@4.7.8)(underscore@1.13.7)) @@ -1296,6 +1296,14 @@ packages: resolution: {integrity: sha512-Ey6176gZmeqZuY/W/nZiUyvmb1/qInjcpiZjXWi6nON+nxJpD1bxtSoBxNliGISae32n6OwbY+TSXPZ1CfS4bw==} engines: {node: '>=18'} + '@istanbuljs/load-nyc-config@1.1.0': + resolution: {integrity: sha512-VjeHSlIzpv/NyD3N0YuHfXOPDIixcA1q2ZV98wsMqcYlPmv2n3Yb2lYP9XMElnaFVXg5A7YLTeLu6V84uQDjmQ==} + engines: {node: '>=8'} + + '@istanbuljs/schema@0.1.3': + resolution: {integrity: sha512-ZXRY4jNvVgSVQ8DL3LTcakaAtXwTVUxE81hslsyD2AtoXW/wVob10HkOJ1X/pAlcI7D+2YoZKg5do8G/w6RYgA==} + engines: {node: '>=8'} + '@jridgewell/gen-mapping@0.3.8': resolution: {integrity: sha512-imAbBGkb+ebQyxKgzv5Hu2nmROxoDOXHh80evxdoXNOrvAnVx7zimzc1Oo5h9RlfV4vPXaE2iM5pOFbvOCClWA==} engines: {node: '>=6.0.0'} @@ -2126,6 +2134,10 @@ packages: resolution: {integrity: sha512-QWjjFgSKtSRIcsBhJmEwS2laIdrA6na8HAlc/pEAhjHgQsah/gMiBFRZvbQTy//hWxR4BMwV7/Mya7q5H8uHeA==} engines: {node: 10.* || >= 12.*} + babel-plugin-istanbul@6.1.1: + resolution: {integrity: sha512-Y1IQok9821cC9onCx5otgFfRm7Lm+I+wwxOx738M/WLPZ9Q42m4IG5W0FNX8WLL2gYMZo3JkuXIH2DOpWM+qwA==} + engines: {node: '>=8'} + babel-plugin-module-resolver@3.2.0: resolution: {integrity: sha512-tjR0GvSndzPew/Iayf4uICWZqjBwnlMWjSx6brryfQ81F9rxBVqwDJtFCV8oOs0+vJeefK9TmdZtkIFdFe1UnA==} engines: {node: '>= 6.0.0'} @@ -3492,6 +3504,18 @@ packages: resolution: {integrity: sha512-PdsSnWK6OkPQJMxkw/J+5TU2uaVm5KCb9gk8fad/bhwkMjkl6TMvPNyFkqtfxVhh7tGfs0Ka4Xjsi6oQzyigeg==} engines: {node: 14.* || >= 16} + ember-cli-code-coverage@3.1.0: + resolution: {integrity: sha512-ODRYNClYaUglbGZX86iOhOTIZI86QDxmEgKVHqaPjQNKKhoBeJcfb9n4sRSFK8w6YrYsjenKI6V6h9oT3lVhtg==} + engines: {node: '>= 18'} + peerDependencies: + '@embroider/compat': ^0.47.0 || ^1.0.0 || ^2.0.0 || >=3.0.0 + '@embroider/core': ^0.47.0 || ^1.0.0 || ^2.0.0 || >=3.0.0 + peerDependenciesMeta: + '@embroider/compat': + optional: true + '@embroider/core': + optional: true + ember-cli-dependency-checker@3.3.2: resolution: {integrity: sha512-PwkrW5oYsdPWwt+0Tojufmv/hxVETTjkrEdK7ANQB2VSnqpA5UcYubwpQM9ONuR2J8wyNDMwEHlqIrk/FYtBsQ==} engines: {node: '>= 6'} @@ -3535,10 +3559,6 @@ packages: resolution: {integrity: sha512-Jb2zbE5Kfe56Nf4IpdaQ10zZ72p/RyLdgE5j5/lKG3I94QHlq+7AkAd18nPpb5OUeRUT13yQTAYpU+MbjpKTtg==} engines: {node: 16.* || >= 18} - ember-cli-qrcode@2.1.0: - resolution: {integrity: sha512-fwT6fRcUuzSphpEOhDH+//L4LPMgcx7HIzV5ksUL1innbsA30u8l22CB0S3Bfb7dkCdoHtV4QCbuNjo0i6bjvg==} - engines: {node: 12.* || 14.* || >= 16} - ember-cli-sri@2.1.1: resolution: {integrity: sha512-YG/lojDxkur9Bnskt7xB6gUOtJ6aPl/+JyGYm9HNDk3GECVHB3SMN3rlGhDKHa1ndS5NK2W2TSLb9bzRbGlMdg==} engines: {node: '>= 0.10.0'} @@ -4338,6 +4358,10 @@ packages: resolution: {integrity: sha512-VW6Pxhsrk0KAOqs3WEd0klDiF/+V7gQOpAvY1jVU/LHmaD/kQO4523aiJuikX/QAKYiW6x8Jh+RJej1almdtCA==} engines: {node: '>= 0.4'} + get-package-type@0.1.0: + resolution: {integrity: sha512-pjzuKtY64GYfWizNAJ0fr9VqttZkNiK2iS430LtIHzjBEr6bX8Am2zm4sW4Ro5wjWW5cAlRL1qAMTcXbjNAO2Q==} + engines: {node: '>=8.0.0'} + get-proto@1.0.1: resolution: {integrity: sha512-sTSfBjoXBp89JvIKIefqw7U2CCebsc74kiY6awiGogKtoSGbgjYE/G/+l9sF3MWFPNc9IcoOC4ODfKHfxFmp0g==} engines: {node: '>= 0.4'} @@ -4593,6 +4617,9 @@ packages: resolution: {integrity: sha512-Y22oTqIU4uuPgEemfz7NDJz6OeKf12Lsu+QC+s3BVpda64lTiMYCyGwg5ki4vFxkMwQdeZDl2adZoqUgdFuTgQ==} engines: {node: '>=18'} + html-escaper@2.0.2: + resolution: {integrity: sha512-H2iMtd0I4Mt5eYiapRdIDjp+XzelXQ0tFE4JS7YFwFevXXMmOp9myNrUvCg0D6ws8iqkRPBfKHgbwig1SmlLfg==} + html-tags@3.3.1: resolution: {integrity: sha512-ztqyC3kLto0e9WbNp0aeP+M3kTt+nbaIveGmUxAtZa+8iFgKLUOD4YKM5j+f3QD89bra7UeumolZHKuOXnTmeQ==} engines: {node: '>=8'} @@ -4993,6 +5020,26 @@ packages: resolution: {integrity: sha512-WhB9zCku7EGTj/HQQRz5aUQEUeoQZH2bWcltRErOpymJ4boYE6wL9Tbr23krRPSZ+C5zqNSrSw+Cc7sZZ4b7vg==} engines: {node: '>=0.10.0'} + istanbul-lib-coverage@3.2.2: + resolution: {integrity: sha512-O8dpsF+r0WV/8MNRKfnmrtCWhuKjxrq2w+jpzBL5UZKTi2LeVWnWOmWRxFlesJONmc+wLAGvKQZEOanko0LFTg==} + engines: {node: '>=8'} + + istanbul-lib-instrument@5.2.1: + resolution: {integrity: sha512-pzqtp31nLv/XFOzXGuvhCb8qhjmTVo5vjVk19XE4CRlSWz0KoeJ3bw9XsA7nOp9YBf4qHjwBxkDzKcME/J29Yg==} + engines: {node: '>=8'} + + istanbul-lib-report@3.0.1: + resolution: {integrity: sha512-GCfE1mtsHGOELCU8e/Z7YWzpmybrx/+dSTfLrvY8qRmaY6zXTKWn6WQIjaAFw069icm6GVMNkgu0NzI4iPZUNw==} + engines: {node: '>=10'} + + istanbul-lib-source-maps@4.0.1: + resolution: {integrity: sha512-n3s8EwkdFIJCG3BPKBYvskgXGoy88ARzvegkitk60NxRdwltLOTaH7CUiMRXvwYorl0Q712iEjcWB+fK/MrWVw==} + engines: {node: '>=10'} + + istanbul-reports@3.1.7: + resolution: {integrity: sha512-BewmUXImeuRk2YY0PVbxgKAysvhRPUQE0h5QRM++nVWyubKGV0l8qQ5op8+B2DOmwSe63Jivj0BjkPQVf8fP5g==} + engines: {node: '>=8'} + istextorbinary@2.1.0: resolution: {integrity: sha512-kT1g2zxZ5Tdabtpp9VSdOzW9lb6LXImyWbzbQeTxoRtHhurC9Ej9Wckngr2+uepPL09ky/mJHmN9jeJPML5t6A==} engines: {node: '>=0.12'} @@ -5317,6 +5364,10 @@ packages: resolution: {integrity: sha512-g3FeP20LNwhALb/6Cz6Dd4F2ngze0jz7tbzrD2wAV+o9FeNHe4rL+yK2md0J/fiSf1sa1ADhXqi5+oVwOM/eGw==} engines: {node: '>=8'} + make-dir@4.0.0: + resolution: {integrity: sha512-hXdUTZYIVOt1Ex//jAQi+wTZZpUpwBj/0QsOzqegb3rGMMeJiSEu5xLHnYfBrRV4RH2+OCSOO95Is/7x1WJ4bw==} + engines: {node: '>=10'} + makeerror@1.0.12: resolution: {integrity: sha512-JmqCvUhmt43madlpFzG4BQzG2Z3m6tvQDNKdClZnO3VbIudJYmxsT0FNJMeiB2+JTSlTQTSbU8QdesVmwJcmLg==} @@ -5578,6 +5629,10 @@ packages: no-case@3.0.4: resolution: {integrity: sha512-fgAN3jGAh+RoxUGZHTSOLJIqUc2wmoBwGR4tbpNAKmmovFoWq0OdRkb0VkldReO2a2iBT/OEulG9XSUc10r3zg==} + node-dir@0.1.17: + resolution: {integrity: sha512-tmPX422rYgofd4epzrNoOXiE8XFZYOcCq1vD7MAXCDO+O+zndlA2ztdKKMa+EeuBG5tHETpr4ml4RGgpqDCCAg==} + engines: {node: '>= 0.10.5'} + node-fetch@2.7.0: resolution: {integrity: sha512-c4FRfUm/dbcWZ7U+1Wq0AwCyFL+3nt2bEw05wfxSz+DWpWsitgmSgYmy2dQdWyKC1694ELPqMs/YzUSNozLt8A==} engines: {node: 4.x || >=6.0.0} @@ -6981,6 +7036,10 @@ packages: engines: {node: '>=10'} hasBin: true + test-exclude@6.0.0: + resolution: {integrity: sha512-cAGWPIyOHU6zlmg88jwm7VRyXnMN7iV68OGAbYDk/Mh/xC/pzVPlQtY6ngoIH/5/tciuhGfvESU8GrHrcxD56w==} + engines: {node: '>=8'} + testem@3.15.2: resolution: {integrity: sha512-mRzqZktqTCWi/rUP/RQOKXvMtuvY3lxuzBVb1xGXPnRNGMEj/1DaLGn6X447yOsz6SlWxSsZfcNuiE7fT1MOKg==} engines: {node: '>= 7.*'} @@ -9298,6 +9357,16 @@ snapshots: '@inquirer/figures@1.0.10': {} + '@istanbuljs/load-nyc-config@1.1.0': + dependencies: + camelcase: 5.3.1 + find-up: 4.1.0 + get-package-type: 0.1.0 + js-yaml: 3.14.1 + resolve-from: 5.0.0 + + '@istanbuljs/schema@0.1.3': {} + '@jridgewell/gen-mapping@0.3.8': dependencies: '@jridgewell/set-array': 1.2.1 @@ -10320,6 +10389,16 @@ snapshots: parse-static-imports: 1.1.0 string.prototype.matchall: 4.0.12 + babel-plugin-istanbul@6.1.1: + dependencies: + '@babel/helper-plugin-utils': 7.26.5 + '@istanbuljs/load-nyc-config': 1.1.0 + '@istanbuljs/schema': 0.1.3 + istanbul-lib-instrument: 5.2.1 + test-exclude: 6.0.0 + transitivePeerDependencies: + - supports-color + babel-plugin-module-resolver@3.2.0: dependencies: find-babel-config: 1.2.2 @@ -12226,6 +12305,25 @@ snapshots: - supports-color - webpack + ember-cli-code-coverage@3.1.0(@embroider/compat@3.8.0(@embroider/core@3.5.0))(@embroider/core@3.5.0): + dependencies: + babel-plugin-istanbul: 6.1.1 + body-parser: 1.20.3 + ember-cli-babel: 7.26.11 + express: 4.21.2 + fs-extra: 9.1.0 + istanbul-lib-coverage: 3.2.2 + istanbul-lib-report: 3.0.1 + istanbul-lib-source-maps: 4.0.1 + istanbul-reports: 3.1.7 + node-dir: 0.1.17 + walk-sync: 2.2.0 + optionalDependencies: + '@embroider/compat': 3.8.0(@embroider/core@3.5.0) + '@embroider/core': 3.5.0 + transitivePeerDependencies: + - supports-color + ember-cli-dependency-checker@3.3.2(ember-cli@5.9.0(handlebars@4.7.8)(underscore@1.13.7)): dependencies: chalk: 2.4.2 @@ -12318,13 +12416,6 @@ snapshots: transitivePeerDependencies: - supports-color - ember-cli-qrcode@2.1.0: - dependencies: - ember-cli-babel: 7.26.11 - ember-cli-htmlbars: 6.3.0 - transitivePeerDependencies: - - supports-color - ember-cli-sri@2.1.1: dependencies: broccoli-sri-hash: 2.1.2 @@ -13878,6 +13969,8 @@ snapshots: hasown: 2.0.2 math-intrinsics: 1.1.0 + get-package-type@0.1.0: {} + get-proto@1.0.1: dependencies: dunder-proto: 1.0.1 @@ -14169,6 +14262,8 @@ snapshots: dependencies: whatwg-encoding: 3.1.1 + html-escaper@2.0.2: {} + html-tags@3.3.1: {} http-errors@1.6.3: @@ -14575,6 +14670,37 @@ snapshots: isobject@3.0.1: {} + istanbul-lib-coverage@3.2.2: {} + + istanbul-lib-instrument@5.2.1: + dependencies: + '@babel/core': 7.24.7(supports-color@8.1.1) + '@babel/parser': 7.26.7 + '@istanbuljs/schema': 0.1.3 + istanbul-lib-coverage: 3.2.2 + semver: 6.3.1 + transitivePeerDependencies: + - supports-color + + istanbul-lib-report@3.0.1: + dependencies: + istanbul-lib-coverage: 3.2.2 + make-dir: 4.0.0 + supports-color: 7.2.0 + + istanbul-lib-source-maps@4.0.1: + dependencies: + debug: 4.4.0(supports-color@8.1.1) + istanbul-lib-coverage: 3.2.2 + source-map: 0.6.1 + transitivePeerDependencies: + - supports-color + + istanbul-reports@3.1.7: + dependencies: + html-escaper: 2.0.2 + istanbul-lib-report: 3.0.1 + istextorbinary@2.1.0: dependencies: binaryextensions: 2.3.0 @@ -14958,6 +15084,10 @@ snapshots: dependencies: semver: 6.3.1 + make-dir@4.0.0: + dependencies: + semver: 7.7.0 + makeerror@1.0.12: dependencies: tmpl: 1.0.5 @@ -15239,6 +15369,10 @@ snapshots: lower-case: 2.0.2 tslib: 2.8.1 + node-dir@0.1.17: + dependencies: + minimatch: 3.1.2 + node-fetch@2.7.0: dependencies: whatwg-url: 5.0.0 @@ -16781,6 +16915,12 @@ snapshots: commander: 2.20.3 source-map-support: 0.5.21 + test-exclude@6.0.0: + dependencies: + '@istanbuljs/schema': 0.1.3 + glob: 7.2.3 + minimatch: 3.1.2 + testem@3.15.2(handlebars@4.7.8)(underscore@1.13.7): dependencies: '@xmldom/xmldom': 0.8.10 diff --git a/tests/test-helper.js b/tests/test-helper.js index 1d0b521b4..743c29c25 100644 --- a/tests/test-helper.js +++ b/tests/test-helper.js @@ -5,10 +5,19 @@ import * as QUnit from 'qunit'; import { setApplication } from '@ember/test-helpers'; import { setup } from 'qunit-dom'; import { start } from 'ember-qunit'; +import { + forceModulesToBeLoaded, + sendCoverage, +} from 'ember-cli-code-coverage/test-support'; setApplication(Application.create(config.APP)); setup(QUnit.assert); setupSinon(); +QUnit.done(async function () { + forceModulesToBeLoaded(); + await sendCoverage(); +}); + start(); From 8a4b7ff7bbe7b2cbacca301457f9bfd7f860d7bc Mon Sep 17 00:00:00 2001 From: tejaskh3 Date: Sat, 19 Apr 2025 01:51:26 +0530 Subject: [PATCH 2/4] feat: add ember-cli-code-coverage --- package.json | 2 +- pnpm-lock.yaml | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index d13471e7c..c3d04685d 100644 --- a/package.json +++ b/package.json @@ -27,7 +27,6 @@ "start": "ember serve", "test": "concurrently \"pnpm:lint\" \"pnpm:test:*\" --names \"lint,test:\"", "test:ember": "ember test", - "test:coverage": "COVERAGE=true ember test", "preinstall": "npx only-allow pnpm" }, "dependencies": { @@ -36,6 +35,7 @@ "d3-cloud": "1.2.7", "dotenv": "16.0.2", "ember-cli-fastboot": "4.1.5", + "ember-cli-qrcode": "^2.1.0", "ember-d3": "0.5.1", "ember-phone-input": "^10.0.0", "exists-sync": "0.1.0", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 25b6fdec6..5976f32a6 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -26,6 +26,9 @@ importers: ember-cli-fastboot: specifier: 4.1.5 version: 4.1.5(ember-source@5.9.0(@babel/core@7.24.7)(@glimmer/component@1.1.2(@babel/core@7.24.7))(rsvp@4.8.5)(webpack@5.91.0)) + ember-cli-qrcode: + specifier: ^2.1.0 + version: 2.1.0 ember-d3: specifier: 0.5.1 version: 0.5.1 @@ -3559,6 +3562,10 @@ packages: resolution: {integrity: sha512-Jb2zbE5Kfe56Nf4IpdaQ10zZ72p/RyLdgE5j5/lKG3I94QHlq+7AkAd18nPpb5OUeRUT13yQTAYpU+MbjpKTtg==} engines: {node: 16.* || >= 18} + ember-cli-qrcode@2.1.0: + resolution: {integrity: sha512-fwT6fRcUuzSphpEOhDH+//L4LPMgcx7HIzV5ksUL1innbsA30u8l22CB0S3Bfb7dkCdoHtV4QCbuNjo0i6bjvg==} + engines: {node: 12.* || 14.* || >= 16} + ember-cli-sri@2.1.1: resolution: {integrity: sha512-YG/lojDxkur9Bnskt7xB6gUOtJ6aPl/+JyGYm9HNDk3GECVHB3SMN3rlGhDKHa1ndS5NK2W2TSLb9bzRbGlMdg==} engines: {node: '>= 0.10.0'} @@ -12416,6 +12423,13 @@ snapshots: transitivePeerDependencies: - supports-color + ember-cli-qrcode@2.1.0: + dependencies: + ember-cli-babel: 7.26.11 + ember-cli-htmlbars: 6.3.0 + transitivePeerDependencies: + - supports-color + ember-cli-sri@2.1.1: dependencies: broccoli-sri-hash: 2.1.2 From 3a8bb0fb5a2b64ae72c911d7746abfa53bc4b201 Mon Sep 17 00:00:00 2001 From: tejaskh3 Date: Sat, 19 Apr 2025 01:58:09 +0530 Subject: [PATCH 3/4] test: branch coverage comment on PR --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index 97747f98a..884f87f29 100644 --- a/README.md +++ b/README.md @@ -54,3 +54,5 @@ Specify what it takes to deploy your app. - Development Browser Extensions - [ember inspector for chrome](https://chrome.google.com/webstore/detail/ember-inspector/bmdblncegkenkacieihfhpjfppoconhi) - [ember inspector for firefox](https://addons.mozilla.org/en-US/firefox/addon/ember-inspector/) + +# testing commit From 4aa58ad7778744be6819566217dd750643f607eb Mon Sep 17 00:00:00 2001 From: tejaskh3 Date: Sat, 19 Apr 2025 02:17:35 +0530 Subject: [PATCH 4/4] fix test case --- .../components/profile/upload-image-test.js | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/tests/integration/components/profile/upload-image-test.js b/tests/integration/components/profile/upload-image-test.js index 387fb291f..31e8cc516 100644 --- a/tests/integration/components/profile/upload-image-test.js +++ b/tests/integration/components/profile/upload-image-test.js @@ -1,7 +1,6 @@ import { module, test } from 'qunit'; import { setupRenderingTest } from 'ember-qunit'; import { render, triggerEvent } from '@ember/test-helpers'; -import { waitFor } from '@ember/test-helpers'; import { hbs } from 'ember-cli-htmlbars'; module('Integration | Component | image uploader', function (hooks) { @@ -76,13 +75,12 @@ module('Integration | Component | image uploader', function (hooks) { await triggerEvent('[data-test-btn="upload-image"]', 'click', { dataTransfer, }); - await waitFor('p.message-text__failure'); - assert - .dom('p.message-text__failure') - .hasText( - 'Error occured, please try again and if the issue still exists contact administrator and create a issue on the repo with logs', - ); + .dom('h1') + .hasText('Crop Selected Image', 'Crop UI is shown after selecting file'); + assert + .dom('[data-test-btn="upload-image"]') + .exists('Upload button is available'); }); test('it renders crop UI when an image is selected', async function (assert) {