Commits since client release/prod push

[RedFlames]

The last Client release is dated 2022-01-22 on Gamebanana et al?

Latest Server update was after the commits on 2022-02-19 afaict

Server:
0x0ade/CelesteNet@e8e9091...main

Client:
0x0ade/CelesteNet@d5be441...main

---

Open PRs to be potentially merged:

• Features:
  • Chat QoL: Tab completions - Server-side only 0x0ade/CelesteNet#33
    _{- opened 2022-08-21} -- x _{(server-side changes only)}
  • Chat QoL: Tab completions - Server-side only - (new branch) 0x0ade/CelesteNet#46
    _{- opened 2022-10-09} -- 💟 _{(server-side changes only)}
  • Chat QoL: Tab completions 0x0ade/CelesteNet#26
    _{- opened 2022-02-06} -- 💠 _{(would become client-side changes only after #46)}
• Fixes:
  • Fix ghost life cycle edge cases 0x0ade/CelesteNet#29
    _{- opened 2022-05-24} -- 💠 _{(client-side changes only)}

---

Closed PRs that have been merged since:

• Features:

  • Player list splitting 0x0ade/CelesteNet#22
    _{- merged on 2022-02-14 -- (client-side changes only)}

  • Add TCP&UDP ping measurment and display 0x0ade/CelesteNet#27
    _{- merged on 2022-04-10}

• Fixes:

  • Fix some player list elements not getting scaled properly anymore. 0x0ade/CelesteNet#23
    _{- merged on 2022-01-22 -- (client-side changes only)}

  • Fixed some issues with Opacity settings 0x0ade/CelesteNet#24
    _{- merged on 2022-01-29 -- (client-side changes only)}

  • Control panel actions (pause chat autoscroll, etc.) 0x0ade/CelesteNet#25
    _{- merged on 2022-02-14 --} // is actually live, but janky?...

  • Player List "ping" fixes 0x0ade/CelesteNet#28
    _{- opened 2022-04-18} -- 💠 _{(client-side changes only)}

  • Misc rendering fixes (Fonts.Load / List.First / BlurRT null) 0x0ade/CelesteNet#30
    _{- opened 2022-06-07} -- 💠 _{(client-side changes only)}

  • Non-Interactive players respond with "Release Me" to any Grab packet. 0x0ade/CelesteNet#31
    _{- opened 2022-06-11} -- 💠 _{(client-side changes only)}

  • Control Panel chat log less cluttered 0x0ade/CelesteNet#34
    _{- opened 2022-08-24} -- 💟 _{(Server.FrontendModule only)}

  • Prevent chat from opening if keyboard is used for text entry dialog 0x0ade/CelesteNet#35
    _{- opened 2022-08-26} -- 💠 _{(client-side changes only)}

  • Fix missing APIPrefix from Frontend Websocket "update" commands. 0x0ade/CelesteNet#38
    _{- opened 2022-09-04} -- 💟 _{(Server.FrontendModule only)}

  • Emote timeskip fixes for Prologue and EH heart 0x0ade/CelesteNet#39
    _{- opened 2022-09-04} -- 💠 _{(client-side changes only)}

  • Check if guest name is valid user key and avoid leaking it to clients 0x0ade/CelesteNet#40
    _{- opened 2022-09-10} -- 💟 _{(server-side changes only)}

  • Prevent chat component NREs when Client is null 0x0ade/CelesteNet#41
    _{- opened 2022-09-15} -- 💠 _{(client-side changes only)}

  • Resend graphics when hair length change detected 0x0ade/CelesteNet#43
    _{- opened 2022-09-22} -- 💠 _{(client-side changes only)}

---

Messed around with Github API and git-log to find all commits that don't come from these merged branches?...

(Side note: Should we rebase before merges so that the commits don't get spliced into the existing history?)

The stuff I did, just for reference

for pull in 22 23 24 25 27; do 
     curl -s -H "Accept: application/vnd.github+json" -H "Authorization: token $PAT" "https://api.github.com/repos/0x0ade/CelesteNet/pulls/$pull/commits > pr_$pull.txt
done

for pull in 22 23 24 25 27; do
     commits="$(jq -r '.[]|.sha' < pr_$pull.txt)"
     echo "$commits"
done | tr -d '\r' > pr_commits.txt

git log --no-merges --since=2022-01-19 --oneline --no-abbrev-commit | grep -v -f pr_commits.txt

non-merge commits

2022-01-22 18:15:22     2d4bb16         Popax21         Clean up/Fix legacy code
2022-01-22 18:47:41     ea2913e         Popax21         Cleanup context core dispose
2022-01-22 18:58:47     d5be441         Popax21         Fix client disconnecting
2022-01-22 19:05:43     72742a7         Jade Macho      Cleanup
2022-01-22 19:18:16     62e3d7a         Jade Macho      Fix disconnect reason handler
2022-01-30 17:17:47     0328e1e         Popax21         Fix connection race condition
--- the above are probably already in server but not in client?...
2022-03-19 15:02:19     c55d6b3         Popax21         Improved connection disposal race condition handling
2022-07-03 01:05:06     9c1c404         Popax21         Fix UDP socket having incorrect address family

[RedFlames]

TODO: Update this comment.

I've been reviewing these again.

Closed/merged PRs:

• Player list splitting (client-only changes)
  Been a while since I looked at all this myself but still looks fine to me and had been reviewed by jade already.
• ping
  Looks fine to me if we merge Player List "ping" fixes 0x0ade/CelesteNet#28 on top of it.
• 2 merged client fixes
  Both look good to me too.

Didn't actually look at the Control panel PR of mine again... not very relevant for public release and can be dealt with later.

Open PRs:

• Chat QoL: Tab completions - Server-side only
  Still needs to be reviewed by others, but once we merge this, the other "Chat QoL" PR will be client-side only
• ping fixes
  See merged ping PR above
• Ghost life cycle
  Not sure I know enough about the Ghosts logic but looks like refactor + cleanup to me.
  📝 Note: Has a FIXME: NOTE BEFORE MERGING: ... in the code, check the diff
• Misc render fixes
  Three fixes that aren't related at all. The first one seems the most important to merge, because it causes those excessive calls to Emoji.Fill
• Interactions bug with the "Release me"
  Kind of a critical fix, since the logic for when to SendReleaseMe() was very flawed.
• Control Panel chat log less cluttered
  Would love to see this get merged as well, even if it's not the ideal solution to the existing problem.

Open PRs for future releases:

• Chat QoL improvements: Scrolling, Tab completions
  TODO: Look at again. Update if we do merge #33 first. Push back to later client update?