fix(metrics): discard undefined responseTimes

Author: gergelyke

lib/agent/metrics/externalEdge/index.js

@@ -1,3 +1,4 @@
+var debug = require('debug')('risingstack/trace')
 var flatMap = require('lodash.flatmap')
 var consts = require('../../../consts')
 
@@ -36,6 +37,12 @@ ExternalEdgeMetrics.prototype.initProtocol = function (data) {
 }
 
 ExternalEdgeMetrics.prototype.report = function (data) {
+  // protect against bad use of the report function: responseTime is required
+  // TODO: check all instrumentations to be sure they send a responseTime
+  if (!data.responseTime) {
+    debug('ExternalEdgeMetrics.report responseTime is undefined, discarding')
+    return
+  }
   this.initProtocol(data)
   var edge = this.initHost(data)
 

lib/agent/metrics/externalEdge/index.spec.js

@@ -3,6 +3,32 @@ var expect = require('chai').expect
 var ExternalEdgeMetrics = require('./')
 
 describe('The ExternalEdgeMetrics module', function () {
+  it('discards undefined responseTime values', function () {
+    var ISOString = 'date-string'
+    var collectorApi = {
+      sendExternalEdgeMetrics: this.sandbox.spy()
+    }
+
+    var edgeMetrics = ExternalEdgeMetrics.create({
+      collectorApi: collectorApi,
+      config: {
+        collectInterval: 1
+      }
+    })
+
+    this.sandbox.stub(Date.prototype, 'toISOString', function () {
+      return ISOString
+    })
+
+    edgeMetrics.report({
+      targetHost: 'rstckapp.com',
+      protocol: 'psql',
+      status: 0
+    })
+
+    expect(edgeMetrics.metrics).to.eql({})
+  })
+
   it('sends metrics', function () {
     var ISOString = 'date-string'
     var collectorApi = {