[Feat/give point when signup] - 새로운 유저 기본포인트 지급 #107
Conversation
WalkthroughInline comments were added to the user registration method to clarify process steps. The user creation logic was updated so that new users start with 10 "love points" instead of zero. A new test verifies that users receive 10 love points upon signup by checking the relevant API response field. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant AuthController
participant SignUpUsecaseImpl
participant UserCreator
participant MainAPI
Client->>AuthController: POST /signup (token, username)
AuthController->>SignUpUsecaseImpl: register(token, username)
Note right of SignUpUsecaseImpl: 1. Validate token\n2. Create user
SignUpUsecaseImpl->>UserCreator: createUser(...)
UserCreator-->>SignUpUsecaseImpl: User with 10 love points
Note right of SignUpUsecaseImpl: 3. (If Apple) Create Apple token\n4. Grant welcome reward
SignUpUsecaseImpl-->>AuthController: Signup response (access/refresh tokens)
AuthController-->>Client: Signup response
Client->>MainAPI: GET /api/v1/main (with access token)
MainAPI-->>Client: Response (love_point = 10)
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
src/main/java/org/runimo/runimo/auth/service/SignUpUsecaseImpl.java(1 hunks)src/main/java/org/runimo/runimo/user/service/UserCreator.java(2 hunks)src/test/java/org/runimo/runimo/auth/controller/AuthAcceptanceTest.java(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build and analyze
🔇 Additional comments (4)
src/main/java/org/runimo/runimo/user/service/UserCreator.java (2)
22-22: LGTM! Good use of named constant.The constant
GREETING_LOVE_POINTclearly expresses the intent and makes the codebase more maintainable.
52-52: Implementation correctly allocates initial love points.The change from hardcoded zero to using the
GREETING_LOVE_POINTconstant properly implements the feature requirement.src/main/java/org/runimo/runimo/auth/service/SignUpUsecaseImpl.java (1)
43-56: Documentation improvements enhance code readability.The inline comments clearly explain the four main steps of the user registration process, making the code more maintainable.
src/test/java/org/runimo/runimo/auth/controller/AuthAcceptanceTest.java (1)
101-128: Test correctly verifies the love point allocation feature.The acceptance test properly validates that new users receive 10 love points upon signup by checking the
/api/v1/mainendpoint response.
src/test/java/org/runimo/runimo/auth/controller/AuthAcceptanceTest.java
Outdated
Show resolved
Hide resolved
|
작업 내역
Summary by CodeRabbit
New Features
Tests
Documentation