-
Notifications
You must be signed in to change notification settings - Fork 0
[Feat/common pagination response] #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughPagination and filtering were introduced to user record queries, affecting controllers, services, repositories, DTOs, and tests. New classes encapsulate pagination data and request parameters. Controller endpoints and service methods now accept structured queries and return paginated responses. Repository methods were updated for paginated and date-filtered queries. Tests were expanded to validate pagination and empty results. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Controller
participant Service
participant Repository
Client->>Controller: GET /records?page=...&size=...&startDate=...&endDate=...
Controller->>Service: getUserRecordSimpleViewByMonth(RecordQuery)
Service->>Repository: findRecordByUserIdAndBetween(userId, from, to, pageable)
Repository-->>Service: Page<RunningRecord>
Service-->>Controller: PageData<RecordSimpleView>
Controller-->>Client: SuccessPageResponse<RecordSimpleView>
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (11)
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
jeeheaG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
앞으로 목록조회 생기면 이거 기본으로 쓸게요
작업내역
GET /api/v1/records/my요청 페이지네이션 적용Summary by CodeRabbit