BUG - eslint-plugin-fiori-tools meets eslint 8 EOL

[heimwege]

Description

Not actually a bug but none of the other categories either 🤷🏻

Seems like eslint 8.x is EOL but eslint-plugin-fiori-tools does not yet support 9.x

Steps to Reproduce

Steps to reproduce the behavior:

1. try to have 9.x eslint version using eslint-plugin-fiori-tools

Expected results

eslint-plugin-fiori-tools supports eslint 9.x

Actual results

Was not able to migrate to esling 9.x

Version/Components/Environment

Add any other context about the problem here
OS:

• Mac OS
• Windows
• Other

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue might have been missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}

[heimwege]

@devinea are there any plans to adjust eslint-plugin-fiori-tools to the new eslint 9 config?

[devinea]

@heimwege not so far. But it seems like we will need to consider it soon.
FYI @ianquigley-sap

[sz3lbi]

Could you please adjust the plugin? ESLint v8.x has been EOL for more than 6 months.

@devinea

[Kyrodan]

SAP pushes TypeScript. I've just created a fresh new app using latest Application Generator.
Starting lint-Task it writes:

> project1@0.0.1 lint
> eslint ./

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.6.0

YOUR TYPESCRIPT VERSION: 5.8.2

Please only submit bug reports when using the officially supported version.

=============

Please upgrade to ESLint 9 quickly! It's very important in professional development to be able to safely use the linter!

[devinea]

Actively working on this.

[ClementRoyer]

Hey @devinea, could you use a hand on this? Happy to help if there’s anything we can do, just let me know what's left or where I could start.

[devinea]

Thanks - @ClementRoyer
I have #3082 prepared to update this repo to use eslint 9.
We depend on https://www.npmjs.com/package/eslint-plugin-fiori-custom also which is published internally from SAP and that this in progress to upgrade to eslint 9 also.

Hopefully will have news in the next few weeks on this.

[sz3lbi]

@devinea Is there any news on this update?

[devinea]

@devinea Is there any news on this update?

@sz3lbi It is still being progressed slowly. https://www.npmjs.com/package/eslint-plugin-fiori-custom is requires more effort than expected and it also being updated to include more rules.
Thanks for your patience.

[tobiashofmann]

Any progress on this?
ESLint 8 is now out of support since a year. While waiting for the -custom package to be updated, maybe remove eslint-plugin-fiori-tools from the yo templates until the packages eslint-plugin-fiori-tools and eslint-plugin-fiori-custom are updated?

Same issue is also discussed here: #2597

[devinea]

Hi All,
The latest version of @sap-ux/eslint-plugin-fiori-tools now supports eslint 9.
https://www.npmjs.com/package/@sap-ux/eslint-plugin-fiori-tools
See the readme for a guide on how to manually upgrade.