Skip to content

Commit 7b583b1

Browse files
committed
Use inheritance to remove This data member
It's reasonable to say that, for example, sfImage _is_ an sf::Image. This "is-a" relationship is what inheritance does a very good job modeling. By using inheritance to implement CSFML types in terms of their SFML counterpart, we get code that is simpler and easier to read. We also avoid some of the extra "dancing" required to construct a CSFML type from an SFML type. This improves the encapsulation of our CSFML implementation.
1 parent 8113ed2 commit 7b583b1

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

70 files changed

+850
-920
lines changed

.clang-tidy

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ Checks: >
1515
-cppcoreguidelines-macro-usage,
1616
-cppcoreguidelines-narrowing-conversions,
1717
-cppcoreguidelines-no-malloc,
18+
-cppcoreguidelines-non-private-member-variables-in-classes,
1819
-cppcoreguidelines-owning-memory,
1920
-cppcoreguidelines-pro-bounds-array-to-pointer-decay,
2021
-cppcoreguidelines-pro-bounds-constant-array-index,

0 commit comments

Comments
 (0)