Skip to content

Commit feea047

Browse files
committed
to get rid of StrictLogging
1 parent 69d3eba commit feea047

File tree

6 files changed

+16
-18
lines changed

6 files changed

+16
-18
lines changed

build.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ ThisBuild / organization := "app.softnetwork"
22

33
name := "resource"
44

5-
ThisBuild / version := "0.5.1"
5+
ThisBuild / version := "0.5.2"
66

77
ThisBuild / scalaVersion := "2.12.18"
88

core/src/main/scala/app/softnetwork/resource/launch/ResourceGuardian.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@ import app.softnetwork.resource.model.GenericResource
1212
import app.softnetwork.resource.persistence.query.GenericResourceToExternalProcessorStream
1313
import app.softnetwork.session.CsrfCheck
1414
import app.softnetwork.session.launch.SessionGuardian
15-
import com.typesafe.scalalogging.StrictLogging
1615

17-
trait ResourceGuardian[Resource <: GenericResource] extends SessionGuardian with StrictLogging {
16+
trait ResourceGuardian[Resource <: GenericResource] extends SessionGuardian {
1817
_: SchemaProvider with CsrfCheck =>
1918

2019
def resourceEntity

core/src/main/scala/app/softnetwork/resource/persistence/query/LocalFileSystemResourceProvider.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import org.json4s.Formats
88
import java.io.ByteArrayInputStream
99
import java.nio.file.attribute.BasicFileAttributes
1010
import java.nio.file.{Files, LinkOption, Paths}
11-
import java.util.Date
1211
import scala.util.{Failure, Success, Try}
1312

1413
protected[resource] trait LocalFileSystemResourceProvider
@@ -58,7 +57,7 @@ protected[resource] trait LocalFileSystemResourceProvider
5857
} match {
5958
case Success(s) => s
6059
case Failure(f) =>
61-
logger.error(f.getMessage, f)
60+
log.error(f.getMessage, f)
6261
None
6362
}
6463
}

core/src/main/scala/app/softnetwork/resource/service/ResourceService.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import app.softnetwork.session.config.Settings
1818
import app.softnetwork.session.model.{SessionData, SessionDataCompanion, SessionDataDecorator}
1919
import app.softnetwork.session.service.{ServiceWithSessionDirectives, SessionMaterials}
2020
import com.softwaremill.session.SessionConfig
21-
import com.typesafe.scalalogging.StrictLogging
2221
import de.heikoseeberger.akkahttpjson4s.Json4sSupport
2322
import org.json4s.{jackson, Formats}
2423
import org.json4s.jackson.Serialization
@@ -29,7 +28,6 @@ trait ResourceService[SD <: SessionData with SessionDataDecorator[SD]]
2928
extends Directives
3029
with DefaultComplete
3130
with Json4sSupport
32-
with StrictLogging
3331
with ServiceWithSessionDirectives[ResourceCommand, ResourceResult, SD]
3432
with LoadResourceService
3533
with ApiRoute {

core/src/main/scala/app/softnetwork/resource/spi/LocalFileSystemProvider.scala

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,17 @@ import app.softnetwork.resource.config.ResourceSettings.{
1010
}
1111
import app.softnetwork.utils.ImageTools.ImageSize
1212
import app.softnetwork.utils.{Base64Tools, ImageTools}
13-
import com.typesafe.scalalogging.StrictLogging
13+
import org.slf4j.Logger
1414

1515
import java.nio.file.{Files, LinkOption, Path, Paths}
1616
import java.util.stream.Collectors
1717
import scala.collection.JavaConverters._
1818
import scala.util.matching.Regex
1919
import scala.util.{Failure, Success, Try}
2020

21-
trait LocalFileSystemProvider extends ResourceProvider with StrictLogging {
21+
trait LocalFileSystemProvider extends ResourceProvider {
22+
23+
def log: Logger
2224

2325
lazy val rootDir = s"$ResourceDirectory/$environment"
2426

@@ -40,8 +42,8 @@ trait LocalFileSystemProvider extends ResourceProvider with StrictLogging {
4042
val dir = Paths.get(rootDir, uri.getOrElse(""))
4143
if (!Files.exists(dir)) {
4244
Try(Files.createDirectories(dir)) match {
43-
case Success(_) => logger.info(s"$dir created successfully")
44-
case Failure(f) => logger.error(s"$dir can not be created -> ${f.getMessage}", f)
45+
case Success(_) => log.info(s"$dir created successfully")
46+
case Failure(f) => log.error(s"$dir can not be created -> ${f.getMessage}", f)
4547
}
4648
}
4749
val decoded = Base64Tools.decodeBase64(data)
@@ -55,7 +57,7 @@ trait LocalFileSystemProvider extends ResourceProvider with StrictLogging {
5557
} match {
5658
case Success(_) => true
5759
case Failure(f) =>
58-
logger.error(f.getMessage, f)
60+
log.error(f.getMessage, f)
5961
false
6062
}
6163
}
@@ -138,7 +140,7 @@ trait LocalFileSystemProvider extends ResourceProvider with StrictLogging {
138140
} match {
139141
case Success(_) => true
140142
case Failure(f) =>
141-
logger.error(f.getMessage, f)
143+
log.error(f.getMessage, f)
142144
false
143145
}
144146
}
@@ -155,8 +157,8 @@ trait LocalFileSystemProvider extends ResourceProvider with StrictLogging {
155157
val dir = Paths.get(rootDir, LibraryDirectory, strictUri(uri))
156158
if (!Files.exists(dir)) {
157159
Try(Files.createDirectories(dir)) match {
158-
case Success(_) => logger.info(s"$dir created successfully")
159-
case Failure(f) => logger.error(s"$dir can not be created -> ${f.getMessage}", f)
160+
case Success(_) => log.info(s"$dir created successfully")
161+
case Failure(f) => log.error(s"$dir can not be created -> ${f.getMessage}", f)
160162
}
161163
}
162164
Files
@@ -195,7 +197,7 @@ trait LocalFileSystemProvider extends ResourceProvider with StrictLogging {
195197
)
196198
})
197199
case Failure(f) =>
198-
logger.error(f.getMessage, f)
200+
log.error(f.getMessage, f)
199201
List.empty
200202
}
201203
}

testkit/src/main/scala/app/softnetwork/resource/scalatest/ResourceToLocalFileSystemRouteTestKit.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ trait ResourceToLocalFileSystemRouteTestKit[SD <: SessionData with SessionDataDe
8686
strictUri = strictUri.substring(7)
8787
}
8888
val path = s"$rootDir$strictUri/$sessionUuid"
89-
logger.info(path)
89+
log.info(path)
9090
assert(Files.exists(Paths.get(path)))
9191
refreshSession(headers)
9292
withHeaders(
@@ -114,7 +114,7 @@ trait ResourceToLocalFileSystemRouteTestKit[SD <: SessionData with SessionDataDe
114114
strictUri = strictUri.substring(7)
115115
}
116116
val path = s"$rootDir$strictUri/$sessionUuid"
117-
logger.info(path)
117+
log.info(path)
118118
assert(!Files.exists(Paths.get(path)))
119119
refreshSession(headers)
120120
withHeaders(

0 commit comments

Comments
 (0)