Skip to content

Commit 311d3a1

Browse files
committed
Refactor parent_intervals to use snapshot_batches
1 parent b557447 commit 311d3a1

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

sqlmesh/core/context.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ def __init__(
278278
default_dialect: t.Optional[str] = None,
279279
default_catalog: t.Optional[str] = None,
280280
is_restatement: t.Optional[bool] = None,
281-
parent_intervals: t.Optional[t.List[Intervals]] = None,
281+
parent_intervals: t.Optional[Intervals] = None,
282282
variables: t.Optional[t.Dict[str, t.Any]] = None,
283283
blueprint_variables: t.Optional[t.Dict[str, t.Any]] = None,
284284
):
@@ -320,7 +320,7 @@ def is_restatement(self) -> t.Optional[bool]:
320320
return self._is_restatement
321321

322322
@property
323-
def parent_intervals(self) -> t.Optional[t.List[Intervals]]:
323+
def parent_intervals(self) -> t.Optional[Intervals]:
324324
return self._parent_intervals
325325

326326
def var(self, var_name: str, default: t.Optional[t.Any] = None) -> t.Optional[t.Any]:

sqlmesh/core/scheduler.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ def batch_intervals(
352352
)
353353
for snapshot, intervals in merged_intervals.items()
354354
}
355-
snapshot_batches = {}
355+
snapshot_batches: t.Dict[Snapshot, Intervals] = {}
356356
all_unready_intervals: t.Dict[str, set[Interval]] = {}
357357
for snapshot_id in dag:
358358
if snapshot_id not in snapshot_intervals:
@@ -364,12 +364,13 @@ def batch_intervals(
364364

365365
adapter = self.snapshot_evaluator.get_adapter(snapshot.model_gateway)
366366

367-
parent_intervals = []
368-
for parent in snapshot.parents:
369-
if parent.snapshot_id not in snapshot_intervals:
367+
parent_intervals: Intervals = []
368+
for parent_id in snapshot.parents:
369+
parent_snapshot, _ = snapshot_intervals.get(parent_id, (None, []))
370+
if not parent_snapshot or parent_snapshot.is_external:
370371
continue
371-
_, p_intervals = snapshot_intervals[parent.snapshot_id]
372-
parent_intervals.append(p_intervals)
372+
373+
parent_intervals.extend(snapshot_batches[parent_snapshot])
373374

374375
context = ExecutionContext(
375376
adapter,

0 commit comments

Comments
 (0)