os/board/rtl8730e: remove rtw_timer.c, rtw_wakelock.c, rtw_atomic.c from lib_wifi_com_sec.a #7051
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ZivLow
commented
Nov 19, 2025
ZivLow
commented
- add linker option --whole-archive so that all the symbols inside static libaries will be looked through
- during linking stage, will encounter undefined reference to pmu_yield_os_check, pmu_acquire_wakelock, pmu_release_wakelock when using linker option --whole-archive on EXTRA_LIBS, because linker will looking through all the symbols
- remove rtw_timer.c, rtw_wakelock.c, rtw_atomic.c from lib_wifi_com_sec.a, so that linker will use the customized rtw_timer.c, rtw_wakelock.c, rtw_atomic.c source files compiled directly at TizenRT, instead of using the definitions from lib_wifi_com_sec.a
- in order to make linker prefer the rtw_timer, rtw_wakelock, rtw_atomic symbols compiled directly at TizenRT, these symbols have been changed to weak inside the wifi static libraries lib_wifi_inic_ap.a, lib_wpa_lite.a, lib_wps.a
…TRA_LIBS
- add linker option --whole-archive so that all the symbols inside static libaries will be looked through
- from linux man pages for ld (linker)
--whole-archive
For each archive mentioned on the command line after the
--whole-archive option, include every object file in the archive in
the link, rather than searching the archive for the required object
files. This is normally used to turn an archive file into a shared
library, forcing every object to be included in the resulting
shared library. This option may be used more than once.
Two notes when using this option from gcc: First, gcc doesn't know
about this option, so you have to use -Wl,-whole-archive. Second,
don't forget to use -Wl,-no-whole-archive after your list of
archives, because gcc will add its own list of archives to your
link and you may not want this flag to affect those as well.
…rom lib_wifi_com_sec.a - during linking stage, will encounter undefined reference to pmu_yield_os_check, pmu_acquire_wakelock, pmu_release_wakelock when using linker option --whole-archive on EXTRA_LIBS, because linker will looking through all the symbols - remove rtw_timer.c, rtw_wakelock.c, rtw_atomic.c from lib_wifi_com_sec.a, so that linker will use the customized rtw_timer.c, rtw_wakelock.c, rtw_atomic.c source files compiled directly at TizenRT, instead of using the definitions from lib_wifi_com_sec.a - in order to make linker prefer the rtw_timer, rtw_wakelock, rtw_atomic symbols compiled directly at TizenRT, these symbols have been changed to weak inside the wifi static libraries lib_wifi_inic_ap.a, lib_wpa_lite.a, lib_wps.a
ZivLow
force-pushed
the
ailite_undefined_reference_pmu_function
branch
from
08fa4cb to
71be477
Compare
sunghan-chang
approved these changes
Nov 27, 2025
Contributor
|
@hk-gwak This is the PR for wifi. Please review and merge this. |
Collaborator
|
Why rtw_timer.c, rtw_wakelock.c, rtw_atomic.c is moved out of lib_wifi_com_sec.a? |
vibhor-m
reviewed
Dec 8, 2025
| @@ -1,5 +1,9 @@ | |||
| /* == "version" + "Realtek git version" + "compile date" + "compile time" == */ | |||
|
|
|||
| == version 8382ffd8 2025/11/19-17:07:47 == | |||
Contributor
Author
Samsung product code seems to have different build process compared to public github TizenRT, and will look through the symbols like at lib_wifi_com_sec.a, instead of the normal default gcc linker behaviour of finding the first symbol definition, and then ignore the rest of symbol definitions in other libraries. Technically, I think it is possible to have the compiled customized rtw_timer.c, rtw_wakelock.c, rtw_atomic.c inside lib_wifi_com_sec.a, and then remove the rtw_timer.c, rtw_wakelock.c, rtw_atomic.c source files in TizenRT. But leaving the source code open in github TizenRT may be helpful when using debugger on CA32. |
hk-gwak
approved these changes
Dec 9, 2025
Collaborator
hk-gwak
left a comment
hk-gwak
left a comment
There was a problem hiding this comment.
Thank you for the comment and mail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.