Skip to content

Conversation

@stephenworsley
Copy link
Contributor

Addresses #6755 (until a better solution is implemented).

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.37%. Comparing base (af100e4) to head (b3bbc3a).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6767      +/-   ##
==========================================
+ Coverage   90.30%   90.37%   +0.06%     
==========================================
  Files          91       91              
  Lines       24674    24746      +72     
  Branches     4623     4635      +12     
==========================================
+ Hits        22282    22363      +81     
+ Misses       1620     1610      -10     
- Partials      772      773       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stephenworsley stephenworsley marked this pull request as ready for review October 30, 2025 12:17
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mechanics looks fine, and I'm sure it works.
Some suggestions though about : increasing user clarity; supporting permanent setting; testing for both cases

stephenworsley and others added 4 commits October 30, 2025 14:47
Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
@pp-mo pp-mo linked an issue Oct 30, 2025 that may be closed by this pull request
@pp-mo pp-mo enabled auto-merge (squash) October 30, 2025 17:11
@pp-mo pp-mo merged commit a12c0c8 into SciTools:main Oct 30, 2025
22 checks passed
@pp-mo
Copy link
Member

pp-mo commented Oct 30, 2025

Thanks @stephenworsley . All good now, I think.

I had previously sort-of skipped over the use of __bool__, which allows if _CONCRETE_DERIVED_LOADING:
That is cool 😎 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Performance regression loading pp files with 3.13

2 participants