-
Notifications
You must be signed in to change notification settings - Fork 297
Temporary fix to ensure coordinate realisation during pp load #6767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ates during pp load
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6767 +/- ##
==========================================
+ Coverage 90.30% 90.37% +0.06%
==========================================
Files 91 91
Lines 24674 24746 +72
Branches 4623 4635 +12
==========================================
+ Hits 22282 22363 +81
+ Misses 1620 1610 -10
- Partials 772 773 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mechanics looks fine, and I'm sure it works.
Some suggestions though about : increasing user clarity; supporting permanent setting; testing for both cases
Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
|
Thanks @stephenworsley . All good now, I think. I had previously sort-of skipped over the use of |
Addresses #6755 (until a better solution is implemented).