Fixes for scroll wheel in ScrollComponent #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, the scroll wheel will only scroll in the entity where the cursor is located. The scroll bar now also recognizes the scroll wheel.
Contributor
|
I disagree with using Windows APIs directly within Proton, even if it's behind an ifdef-guard. I'd use extern variables or functions to get the x/y position of the cursor, and hook WM_MOUSEMOVE to update it. I don't see why the scroll bar didn't fade in when scrolling. This is a good change. |
Owner
|
Appreciate the patch (sorry for the delay) - won't merge right now though, some things have changed since this was written (I added/changed some scroll wheel stuff so my SlideShow project could zoom in/out, it it may need to be tweaked to use that, hope to take a closer look later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, the scroll wheel will only scroll in the entity where the cursor is located. Before, it scrolled every Entity with ScrollComponent existing. The scroll bar now also recognizes the scroll wheel.