Merge pull request #348 from Shopify/lopert.convert-function-unit-tests

Convert function unit tests

Author: lopert

.github/workflows/validate-js-functions.yml

@@ -24,5 +24,3 @@ jobs:
         run: yarn
       - name: Generate types
         run: yarn js-typegen
-      - name: Test
-        run: yarn js-test:unit

.github/workflows/validate-ts-functions.yml

@@ -24,5 +24,3 @@ jobs:
         run: yarn
       - name: Generate types
         run: yarn js-typegen
-      - name: Test
-        run: yarn js-test:unit

functions-cart-checkout-validation-js/src/cart_validations_generate_run.test.liquid

@@ -0,0 +1,29 @@
+{
+  "payload": {
+    "export": "cart-validations-generate-run",
+    "target": "cart.validations.generate.run",
+    "input": {
+      "cart": {
+        "lines": [
+          {
+            "quantity": 3
+          }
+        ]
+      }
+    },
+    "output": {
+      "operations": [
+        {
+          "validationAdd": {
+            "errors": [
+              {
+                "message": "Not possible to order more than one of each",
+                "target": "$.cart"
+              }
+            ]
+          }
+        }
+      ]
+    }
+  }
+}

functions-cart-checkout-validation-js/tests/fixtures/quantity-exceeds-one.json

@@ -4,7 +4,7 @@
   "private": true,
   "type": "module",
   "scripts": {
-    "test": "vitest run"
+    "test": "vitest"
   },
   "devDependencies": {
     "@shopify/shopify-function-test-helpers": "^1.0.0",

…ut-validation-js/tests/fixtures/log.json …n-js/tests/fixtures/quantity-is-one.jsonfunctions-cart-checkout-validation-js/tests/fixtures/log.json renamed to functions-cart-checkout-validation-js/tests/fixtures/quantity-is-one.json functions-cart-checkout-validation-js/tests/fixtures/log.json renamed to functions-cart-checkout-validation-js/tests/fixtures/quantity-is-one.json

@@ -26,66 +26,3 @@ fn cart_validations_generate_run(
 
     Ok(schema::CartValidationsGenerateRunResult { operations })
 }
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use shopify_function::{run_function_with_input, Result};
-
-    #[test]
-    fn test_result_contains_single_error_when_quantity_exceeds_one() -> Result<()> {
-        let result = run_function_with_input(
-            cart_validations_generate_run,
-            r#"
-                {
-                    "cart": {
-                        "lines": [
-                            {
-                                "quantity": 3
-                            }
-                        ]
-                    }
-                }
-            "#,
-        )?;
-        let expected = schema::CartValidationsGenerateRunResult {
-            operations: vec![schema::Operation::ValidationAdd(
-                schema::ValidationAddOperation {
-                    errors: vec![schema::ValidationError {
-                        message: "Not possible to order more than one of each".to_owned(),
-                        target: "$.cart".to_owned(),
-                    }],
-                },
-            )],
-        };
-
-        assert_eq!(result, expected);
-        Ok(())
-    }
-
-    #[test]
-    fn test_result_contains_no_errors_when_quantity_is_one() -> Result<()> {
-        let result = run_function_with_input(
-            cart_validations_generate_run,
-            r#"
-                {
-                    "cart": {
-                        "lines": [
-                            {
-                                "quantity": 1
-                            }
-                        ]
-                    }
-                }
-            "#,
-        )?;
-        let expected = schema::CartValidationsGenerateRunResult {
-            operations: vec![schema::Operation::ValidationAdd(
-                schema::ValidationAddOperation { errors: vec![] },
-            )],
-        };
-
-        assert_eq!(result, expected);
-        Ok(())
-    }
-}

functions-cart-checkout-validation-rs/package.json.liquid

@@ -0,0 +1,29 @@
+{
+  "payload": {
+    "export": "cart_validations_generate_run",
+    "target": "cart.validations.generate.run",
+    "input": {
+      "cart": {
+        "lines": [
+          {
+            "quantity": 3
+          }
+        ]
+      }
+    },
+    "output": {
+      "operations": [
+        {
+          "validationAdd": {
+            "errors": [
+              {
+                "message": "Not possible to order more than one of each",
+                "target": "$.cart"
+              }
+            ]
+          }
+        }
+      ]
+    }
+  }
+}

functions-cart-checkout-validation-rs/src/cart_validations_generate_run.rs

@@ -5,12 +5,6 @@
     "input": {
       "cart": {
         "lines": [
-          {
-            "quantity": 1
-          },
-          {
-            "quantity": 1
-          },
           {
             "quantity": 1
           }

functions-cart-checkout-validation-rs/tests/fixtures/quantity-exceeds-one.json

@@ -0,0 +1,8 @@
+export default {
+  test: {
+    forceRerunTriggers: [
+      '**/tests/fixtures/**',
+      '**/src/**',
+    ],
+  },
+};