From 94abf19cf77e36592ee658ddce706f4be47d6562 Mon Sep 17 00:00:00 2001 From: Scott Wadden Date: Wed, 20 Nov 2024 14:07:33 -0400 Subject: [PATCH 1/6] WIP channel config extension template --- channel-config/README.md.liquid | 1 + channel-config/locales/en.default.json.liquid | 0 channel-config/shopify.extension.toml.liquid | 7 +++++++ templates.json | 17 +++++++++++++++++ 4 files changed, 25 insertions(+) create mode 100644 channel-config/README.md.liquid create mode 100644 channel-config/locales/en.default.json.liquid create mode 100644 channel-config/shopify.extension.toml.liquid diff --git a/channel-config/README.md.liquid b/channel-config/README.md.liquid new file mode 100644 index 00000000..790b6750 --- /dev/null +++ b/channel-config/README.md.liquid @@ -0,0 +1 @@ +## Extension Configuration diff --git a/channel-config/locales/en.default.json.liquid b/channel-config/locales/en.default.json.liquid new file mode 100644 index 00000000..e69de29b diff --git a/channel-config/shopify.extension.toml.liquid b/channel-config/shopify.extension.toml.liquid new file mode 100644 index 00000000..fe34031c --- /dev/null +++ b/channel-config/shopify.extension.toml.liquid @@ -0,0 +1,7 @@ +[[extensions]] +name = "Channel config extension" +type = "channel_config" +handle = "{{ handle }}" +channel_definition_handle = "google" +max_listing_variants = 10 +publication_status_listing_level = "item" diff --git a/templates.json b/templates.json index 5ce9b8d5..46b78930 100644 --- a/templates.json +++ b/templates.json @@ -1065,5 +1065,22 @@ "path": "admin-link" } ] + }, + { + "identifier": "channel_config_template", + "name": "Channel config template", + "defaultName": "channel-config-template", + "group": "Sales channels", + "supportLinks": [], + "url": "https://github.com/Shopify/extensions-templates", + "type": "channel_config", + "extensionPoints": [], + "supportedFlavors": [ + { + "name": "Config only", + "value": "config-only", + "path": "channel-config" + } + ] } ] From d0b67215bd47d10a167c3055b308984963dca6c8 Mon Sep 17 00:00:00 2001 From: Scott Wadden Date: Mon, 2 Dec 2024 21:40:50 +0000 Subject: [PATCH 2/6] wip template changes --- channel-config/shopify.extension.toml.liquid | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/channel-config/shopify.extension.toml.liquid b/channel-config/shopify.extension.toml.liquid index fe34031c..9bf4ce5c 100644 --- a/channel-config/shopify.extension.toml.liquid +++ b/channel-config/shopify.extension.toml.liquid @@ -2,6 +2,5 @@ name = "Channel config extension" type = "channel_config" handle = "{{ handle }}" +{% if uid %}uid = "{{ uid }}"{% endif %} channel_definition_handle = "google" -max_listing_variants = 10 -publication_status_listing_level = "item" From 5a0972298c8d6f31d64d6e39e1c704919ef4cee1 Mon Sep 17 00:00:00 2001 From: Scott Wadden Date: Tue, 3 Dec 2024 14:44:24 +0000 Subject: [PATCH 3/6] Updated WIP channel config template --- channel-config/shopify.extension.toml.liquid | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/channel-config/shopify.extension.toml.liquid b/channel-config/shopify.extension.toml.liquid index 9bf4ce5c..395184cb 100644 --- a/channel-config/shopify.extension.toml.liquid +++ b/channel-config/shopify.extension.toml.liquid @@ -1,6 +1,7 @@ [[extensions]] -name = "Channel config extension" type = "channel_config" handle = "{{ handle }}" {% if uid %}uid = "{{ uid }}"{% endif %} channel_definition_handle = "google" +max_listing_variants = 10 +publication_status_listing_level = "item" \ No newline at end of file From 70ed292a67516b8380c80ee722a0c44e97a758cb Mon Sep 17 00:00:00 2001 From: Catherine Fu Date: Mon, 9 Dec 2024 16:56:05 +0000 Subject: [PATCH 4/6] incorporated product_schema and channel_configs section to channel config extension default template --- channel-config/shopify.extension.toml.liquid | 108 ++++++++++++++++++- 1 file changed, 105 insertions(+), 3 deletions(-) diff --git a/channel-config/shopify.extension.toml.liquid b/channel-config/shopify.extension.toml.liquid index 395184cb..27d36d09 100644 --- a/channel-config/shopify.extension.toml.liquid +++ b/channel-config/shopify.extension.toml.liquid @@ -2,6 +2,108 @@ type = "channel_config" handle = "{{ handle }}" {% if uid %}uid = "{{ uid }}"{% endif %} -channel_definition_handle = "google" -max_listing_variants = 10 -publication_status_listing_level = "item" \ No newline at end of file + +[[extensions]] +type = "channel_config" +handle = "channel-config-template" +uid = "020b85f6-c955-454d-8ec5-629d232db97d" + +[[extensions.channel_configs]] +handle = "eBay" +channel_definition_handle = "ebay" +max_listing_variants = 1000 +publication_status_level = "listing" + +[[extensions.channel_configs.markets]] +handle = "US" +taxonomy_name = "ebay-us" +taxonomy_id = 3 +product_schema = "ebay-us" +languages = ["EN"] + +[[extensions.channel_configs.markets]] +handle = "CAN" +taxonomy_name = "ebay-ca" +taxonomy_id = 4 +product_schema = "ebay-ca" +languages = ["EN", "FR"] + +[[extensions.product_schema]] +handle = "ebay-us" + +[[extensions.product_schema.schema_fields]] +handle = "sku" +resource_type = "ProductVariant" +required_data_type = "string" +enforcement = "recommended" +can_overwrite = true + +[extensions.product_schema.schema_fields.display] +display_name = "SKU" +display_domain = "item_details" +display_order = 1 + +[[extensions.product_schema.schema_fields]] +handle = "title" +resource_type = "Product" +default_source_path = "product.title" +required_data_type = "string" +enforcement = "required" +can_overwrite = true + +[extensions.product_schema.schema_fields.display] +display_name = "Title" +display_domain = "listing_details" +display_order = 2 + +[[extensions.product_schema.schema_fields]] +handle = "subtitle" +resource_type = "Product" +required_data_type = "string" +enforcement = "optional" +can_overwrite = true + +[extensions.product_schema.schema_fields.display] +display_name = "Subtitle" +display_domain = "listing_details" +display_order = 3 + +[[extensions.product_schema]] +handle = "ebay-ca" + +[[extensions.product_schema.schema_fields]] +handle = "sku" +resource_type = "ProductVariant" +required_data_type = "string" +enforcement = "recommended" +can_overwrite = true + +[extensions.product_schema.schema_fields.display] +display_name = "SKU" +display_domain = "item_details" +display_order = 1 + +[[extensions.product_schema.schema_fields]] +handle = "title" +resource_type = "Product" +default_source_path = "product.title" +required_data_type = "string" +enforcement = "required" +can_overwrite = true + +[extensions.product_schema.schema_fields.display] +display_name = "Title" +display_domain = "listing_details" +display_order = 2 + +[[extensions.product_schema.schema_fields]] +handle = "subtitle" +resource_type = "Product" +required_data_type = "string" +enforcement = "required" +can_overwrite = true + +[extensions.product_schema.schema_fields.display] +display_name = "Subtitle" +display_domain = "listing_details" +display_order = 3 From 681721d6c3d4a528463fa3068197761a665a84c9 Mon Sep 17 00:00:00 2001 From: Catherine Fu Date: Mon, 9 Dec 2024 19:06:43 +0000 Subject: [PATCH 5/6] update the default template of channel extension template: 1. rename channel_configs property to channel_requirements 2. add a new property display_domains to channel_requirements --- channel-config/shopify.extension.toml.liquid | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/channel-config/shopify.extension.toml.liquid b/channel-config/shopify.extension.toml.liquid index 27d36d09..35a39451 100644 --- a/channel-config/shopify.extension.toml.liquid +++ b/channel-config/shopify.extension.toml.liquid @@ -8,20 +8,27 @@ type = "channel_config" handle = "channel-config-template" uid = "020b85f6-c955-454d-8ec5-629d232db97d" -[[extensions.channel_configs]] +[[extensions.channel_requirements]] handle = "eBay" channel_definition_handle = "ebay" max_listing_variants = 1000 publication_status_level = "listing" -[[extensions.channel_configs.markets]] +[extensions.channel_requirements.display_domains] +listing_details = 1 +product_attributes = 2 +product_identifier = 3 +offer_information = 4 +product_taxonomy_attributes = 5 + +[[extensions.channel_requirements.markets]] handle = "US" taxonomy_name = "ebay-us" taxonomy_id = 3 product_schema = "ebay-us" languages = ["EN"] -[[extensions.channel_configs.markets]] +[[extensions.channel_requirements.markets]] handle = "CAN" taxonomy_name = "ebay-ca" taxonomy_id = 4 From 5b7170b85fe1b64b70c438bc1c23f29889336249 Mon Sep 17 00:00:00 2001 From: Scott Wadden Date: Mon, 9 Dec 2024 16:11:16 -0400 Subject: [PATCH 6/6] Removed duplicated section in channel-config toml --- channel-config/shopify.extension.toml.liquid | 5 ----- 1 file changed, 5 deletions(-) diff --git a/channel-config/shopify.extension.toml.liquid b/channel-config/shopify.extension.toml.liquid index 35a39451..1fd27be1 100644 --- a/channel-config/shopify.extension.toml.liquid +++ b/channel-config/shopify.extension.toml.liquid @@ -3,11 +3,6 @@ type = "channel_config" handle = "{{ handle }}" {% if uid %}uid = "{{ uid }}"{% endif %} -[[extensions]] -type = "channel_config" -handle = "channel-config-template" -uid = "020b85f6-c955-454d-8ec5-629d232db97d" - [[extensions.channel_requirements]] handle = "eBay" channel_definition_handle = "ebay"