[WIP] INFOMANIAK provider

[jbelien]

Warning

This is a work in progress!

This is a provider for @Infomaniak (https://www.infomaniak.com/).

This is my first contribution in Go and in DNSControl ; any feedback is welcome (even while I'm working on it).

Please create the GitHub label 'provider-INFOMANIAK'.

[jbelien]

I'm currently hitting a bump with the integration tests.

=== RUN   TestDNSProviders
Testing Profile="INFOMANIAK" (TYPE="INFOMANIAK")
=== RUN   TestDNSProviders/glop.be
=== RUN   TestDNSProviders/glop.be/Clean_Slate:Empty
CREATE: [ns12.infomaniak.ch.]
    helpers_integration_test.go:169: 
        - DELETE  NS ns12.infomaniak.ch.glop.be. ttl=3600
    helpers_integration_test.go:174: failed to delete record 25810013 in zone glop.be: Cannot delete object
=== RUN   TestDNSProviders/glop.be/00:A:Create_A
CREATE: [ns12.infomaniak.ch.]
CREATE: [1.1.1.1]
    helpers_integration_test.go:169: 
        - DELETE  NS ns12.infomaniak.ch.glop.be. ttl=3600
    helpers_integration_test.go:174: failed to delete record 25810013 in zone glop.be: Cannot delete object

It seems that I can't delete that NS record.
How should I handle that NS record ?
Is there a way to handle NS record separately ?
Is there a way to "skip" it in the integration tests ?
Thanks!

[tlimoncelli]

It seems that I can't delete that NS record.

Could it be a permission issue?
Many providers don't allow you to delete NS records that they install.

How should I handle that NS record ?
Is there a way to handle NS record separately ?

For now, try skipping if the type == NS. Let's see if A, CNAME, MX have the same problem. If they have the same problem, it could be permissions or a problem with how the API is being used. If the problem is only with NS records, we might just have to skip them.

Is there a way to "skip" it in the integration tests ?

You can! Try go test -v -verbose -profile INFOMANIAK -start 16 -end 20

More info in: https://docs.dnscontrol.org/developer-info/integration-tests

[jbelien]

@tlimoncelli Thanks for your reply! That was indeed the direction I was taking! 👍
I'll come back with some updates in the next few days.

[signalwerk]

@jbelien I'm currently also looking for an Infomaniak integration. It looks like your work is already on a great state! Thank you for your work. Count me in as a beta-tester 👌

[jbelien]

To be honest I'm kind of stuck and didn't have time to continue lately ...

Any help is welcome and appreciated!

But I didn't give up and still think it needs to be added to dnscontrol ! 😁

[signalwerk]

@jbelien I have sent you a PR to build upon your work. Since I'm not a Go developer, I would appreciate it if you could take a look at it. Additionally, please note that I utilized the help of AI in this process. While I believe that’s acceptable, a second pair of eyes would be greatly valued!

[tlimoncelli]

I rebased this. That should make it significantly easier to review. (You may want to use "git pull --rebase --ff-only --prune" to update your local repo)

[signalwerk]

@tlimoncelli perfect! that makes it lot easier. I updated my branch so that you can review my PR better.

[tlimoncelli]

The code looks great so far! Looks like you need to fill in the diff2.CHANGE and diff2.CREATE actions and you should be ready for the integration tests. (That's the fun part!)

[jbelien]

Awesome ! Thanks a lot !

I'll have a look this week and merge your PR into mine (with correct attribution, of course )!

[signalwerk]

@tlimoncelli thanks a lot for your comment!
When you mention diff2.CHANGE, are you referring to something other than this line: infomaniakProvider.go#L311?
If so, could you maybe share a small example or point me to a relevant code? That would really help me understand what you mean. 🙏