TESTS: Supervisord crushes on exceptions while adding process-group

Author: cod1k

supervisor/tests/test_supervisord.py

@@ -834,3 +834,21 @@ def callback(event):
         self.assertEqual(supervisord.ticks[3600], 3600)
         self.assertEqual(len(L), 6)
         self.assertEqual(L[-1].__class__, events.Tick3600Event)
+
+    def test_add_failing_process_group_wont_crush(self):
+        options = DummyOptions()
+        supervisord = self._makeOne(options)
+
+        from unittest import mock
+
+        group = mock.Mock()
+
+        make_group = mock.Mock(side_effect=Exception)
+
+        group.attach_mock(make_group, 'make_group')
+
+        # set up supervisord with an active configuration of group1 and group2
+        supervisord.options.process_group_configs = [group]
+        self.assertFalse(supervisord.add_process_group(group))
+        self.assertTrue(not supervisord.process_groups)
+        self.assertTrue(str(options.logger.data[0]).startswith('Unable to add group'))