fix: correct MSSQL bracket quoting, deduplicate quote helper, restore error context in view fallback

Author: datlechin

TablePro/Core/Autocomplete/CompletionEngine.swift

@@ -36,10 +36,12 @@ final class CompletionEngine {
         dialect: SQLDialectDescriptor? = nil,
         statementCompletions: [CompletionEntry] = []
     ) {
-        self.provider = SQLCompletionProvider(schemaProvider: schemaProvider, databaseType: databaseType, dialect: dialect)
-        if let type = databaseType {
-            self.provider.setDatabaseType(type, dialect: dialect, statementCompletions: statementCompletions)
-        }
+        self.provider = SQLCompletionProvider(
+            schemaProvider: schemaProvider,
+            databaseType: databaseType,
+            dialect: dialect,
+            statementCompletions: statementCompletions
+        )
     }
 
     // MARK: - Public API

TablePro/Core/Autocomplete/SQLCompletionProvider.swift

@@ -26,10 +26,12 @@ final class SQLCompletionProvider {
 
     // MARK: - Init
 
-    init(schemaProvider: SQLSchemaProvider, databaseType: DatabaseType? = nil, dialect: SQLDialectDescriptor? = nil) {
+    init(schemaProvider: SQLSchemaProvider, databaseType: DatabaseType? = nil,
+         dialect: SQLDialectDescriptor? = nil, statementCompletions: [CompletionEntry] = []) {
         self.schemaProvider = schemaProvider
         self.databaseType = databaseType
         self.cachedDialect = dialect
+        self.cachedStatementCompletions = statementCompletions
     }
 
     /// Update the database type for context-aware completions

TablePro/Core/Database/FilterSQLGenerator.swift

@@ -8,20 +8,6 @@
 import Foundation
 import TableProPluginKit
 
-private func quoteIdentifierFromDialect(_ dialect: SQLDialectDescriptor) -> (String) -> String {
-    let q = dialect.identifierQuote
-    if q == "[" {
-        return { name in
-            let escaped = name.replacingOccurrences(of: "]", with: "]]")
-            return "[\(escaped)]"
-        }
-    }
-    return { name in
-        let escaped = name.replacingOccurrences(of: q, with: q + q)
-        return "\(q)\(escaped)\(q)"
-    }
-}
-
 /// Generates SQL WHERE clauses from filter definitions
 struct FilterSQLGenerator {
     private let dialect: SQLDialectDescriptor

TablePro/Core/Utilities/SQL/DialectQuoteHelper.swift

@@ -14,7 +14,10 @@ func quoteIdentifierFromDialect(_ dialect: SQLDialectDescriptor?) -> (String) ->
     guard let dialect else { return { $0 } }
     let q = dialect.identifierQuote
     if q == "[" {
-        return { name in "[\(name.replacingOccurrences(of: "]", with: "]]"))]" }
+        return { name in
+            let escaped = name.replacingOccurrences(of: "]", with: "]]")
+            return "[\(escaped)]"
+        }
     }
     return { name in
         let escaped = name.replacingOccurrences(of: q, with: q + q)

TablePro/Views/Main/Extensions/MainContentCoordinator+SidebarActions.swift

@@ -42,8 +42,9 @@ extension MainContentCoordinator {
                 WindowOpener.shared.openNativeTab(payload)
             } catch {
                 let driver = DatabaseManager.shared.driver(for: self.connection.id)
-                let fallbackSQL = driver?.editViewFallbackTemplate(viewName: viewName)
+                let template = driver?.editViewFallbackTemplate(viewName: viewName)
                     ?? "CREATE OR REPLACE VIEW \(viewName) AS\nSELECT * FROM table_name;"
+                let fallbackSQL = "-- Could not fetch view definition: \(error.localizedDescription)\n\(template)"
 
                 let payload = EditorTabPayload(
                     connectionId: connection.id,