Skip to content

Commit 41e9c1e

Browse files
committed
fix: add no-op transaction methods for non-transactional databases
1 parent 3834232 commit 41e9c1e

3 files changed

Lines changed: 6 additions & 8 deletions

File tree

Plugins/ClickHouseDriverPlugin/ClickHousePlugin.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,9 @@ final class ClickHousePluginDriver: PluginDatabaseDriver, @unchecked Sendable {
6464
var serverVersion: String? { _serverVersion }
6565
var supportsSchemas: Bool { false }
6666
var supportsTransactions: Bool { false }
67+
func beginTransaction() async throws {}
68+
func commitTransaction() async throws {}
69+
func rollbackTransaction() async throws {}
6770
var currentSchema: String? { nil }
6871

6972
init(config: DriverConnectionConfig) {

Plugins/MongoDBDriverPlugin/MongoDBPluginDriver.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ final class MongoDBPluginDriver: PluginDatabaseDriver {
1919
var serverVersion: String? { mongoConnection?.serverVersion() }
2020
var currentSchema: String? { nil }
2121
var supportsTransactions: Bool { false }
22+
func beginTransaction() async throws {}
23+
func commitTransaction() async throws {}
24+
func rollbackTransaction() async throws {}
2225

2326
init(config: DriverConnectionConfig) {
2427
self.config = config

Plugins/OracleDriverPlugin/OraclePlugin.swift

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -86,14 +86,6 @@ final class OraclePluginDriver: PluginDatabaseDriver, @unchecked Sendable {
8686
// Oracle uses implicit transactions — no explicit BEGIN needed
8787
}
8888

89-
func commitTransaction() async throws {
90-
_ = try await execute(query: "COMMIT")
91-
}
92-
93-
func rollbackTransaction() async throws {
94-
_ = try await execute(query: "ROLLBACK")
95-
}
96-
9789
// MARK: - Query Execution
9890

9991
func execute(query: String) async throws -> PluginQueryResult {

0 commit comments

Comments
 (0)