fix: address review issues in plugin marketplace

Author: datlechin

TablePro/Core/Plugins/Registry/PluginManager+Registry.swift

@@ -5,7 +5,6 @@
 
 import CryptoKit
 import Foundation
-import os
 
 extension PluginManager {
     func installFromRegistry(
@@ -40,41 +39,32 @@ extension PluginManager {
             try? FileManager.default.removeItem(at: tempDir)
         }
 
-        let (asyncBytes, response) = try await URLSession.shared.bytes(from: downloadURL)
+        // Use the registry client's configured session for consistent timeouts
+        let session = await RegistryClient.shared.session
+
+        let (tempDownloadURL, response) = try await session.download(from: downloadURL)
 
         guard let httpResponse = response as? HTTPURLResponse,
               (200...299).contains(httpResponse.statusCode) else {
             let statusCode = (response as? HTTPURLResponse)?.statusCode ?? 0
             throw PluginError.downloadFailed("HTTP \(statusCode)")
         }
 
-        let expectedLength = httpResponse.expectedContentLength
-        var downloadedData = Data()
-        if expectedLength > 0 {
-            downloadedData.reserveCapacity(Int(expectedLength))
-        }
-
-        var bytesReceived: Int64 = 0
-        for try await byte in asyncBytes {
-            downloadedData.append(byte)
-            bytesReceived += 1
-
-            if expectedLength > 0, bytesReceived % 65_536 == 0 {
-                let fraction = Double(bytesReceived) / Double(expectedLength)
-                await progress(min(fraction, 1.0))
-            }
-        }
-
-        await progress(1.0)
+        await progress(0.5)
 
+        // Verify SHA-256 checksum
+        let downloadedData = try Data(contentsOf: tempDownloadURL)
         let digest = SHA256.hash(data: downloadedData)
         let hexChecksum = digest.map { String(format: "%02x", $0) }.joined()
 
         if hexChecksum != registryPlugin.sha256.lowercased() {
             throw PluginError.checksumMismatch
         }
 
-        try downloadedData.write(to: tempZipURL)
+        await progress(1.0)
+
+        // Move to our temp directory for installPlugin
+        try FileManager.default.moveItem(at: tempDownloadURL, to: tempZipURL)
 
         return try await installPlugin(from: tempZipURL)
     }

TablePro/Core/Plugins/Registry/RegistryClient.swift

@@ -19,7 +19,7 @@ final class RegistryClient {
         set { UserDefaults.standard.set(newValue, forKey: "registryETag") }
     }
 
-    private let session: URLSession
+    let session: URLSession
     private static let logger = Logger(subsystem: "com.TablePro", category: "RegistryClient")
 
     // swiftlint:disable:next force_unwrapping
@@ -29,11 +29,6 @@ final class RegistryClient {
     private static let manifestCacheKey = "registryManifestCache"
     private static let lastFetchKey = "registryLastFetch"
 
-    private let decoder: JSONDecoder = {
-        let decoder = JSONDecoder()
-        return decoder
-    }()
-
     private init() {
         let config = URLSessionConfiguration.default
         config.timeoutIntervalForRequest = 15
@@ -42,7 +37,7 @@ final class RegistryClient {
         self.session = URLSession(configuration: config)
 
         if let cachedData = UserDefaults.standard.data(forKey: Self.manifestCacheKey),
-           let cached = try? decoder.decode(RegistryManifest.self, from: cachedData) {
+           let cached = try? JSONDecoder().decode(RegistryManifest.self, from: cachedData) {
             manifest = cached
             lastFetchDate = UserDefaults.standard.object(forKey: Self.lastFetchKey) as? Date
         }
@@ -71,7 +66,7 @@ final class RegistryClient {
                 fetchState = .loaded
 
             case 200...299:
-                let decoded = try decoder.decode(RegistryManifest.self, from: data)
+                let decoded = try JSONDecoder().decode(RegistryManifest.self, from: data)
                 manifest = decoded
 
                 UserDefaults.standard.set(data, forKey: Self.manifestCacheKey)
@@ -129,7 +124,7 @@ final class RegistryClient {
     }
 }
 
-enum RegistryFetchState: Equatable {
+enum RegistryFetchState: Equatable, Sendable {
     case idle
     case loading
     case loaded

TablePro/Views/Settings/Plugins/BrowsePluginsView.swift

@@ -117,7 +117,6 @@ struct BrowsePluginsView: View {
                                     plugin: plugin,
                                     isInstalled: isPluginInstalled(plugin.id),
                                     installProgress: installTracker.state(for: plugin.id),
-                                    isExpanded: selectedPluginId == plugin.id,
                                     onInstall: { installPlugin(plugin) },
                                     onToggleDetail: {
                                         withAnimation(.easeInOut(duration: 0.2)) {

TablePro/Views/Settings/Plugins/RegistryPluginRow.swift

@@ -9,7 +9,6 @@ struct RegistryPluginRow: View {
     let plugin: RegistryPlugin
     let isInstalled: Bool
     let installProgress: InstallProgress?
-    let isExpanded: Bool
     let onInstall: () -> Void
     let onToggleDetail: () -> Void