Skip to content

Commit 907bbe8

Browse files
committed
fix: address review feedback on multi-arch plugin registry
1 parent d6cb714 commit 907bbe8

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

.github/workflows/build-plugin.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,8 @@ jobs:
8181
run: ./scripts/build-plugin.sh "${{ steps.plugin-info.outputs.target }}" x86_64
8282

8383
- name: Capture SHA-256 hashes
84+
# Hashes are captured before notarize intentionally: notarytool does not
85+
# modify the ZIP on disk, and stapling applies to app bundles, not ZIPs.
8486
id: sha256
8587
run: |
8688
BUNDLE_NAME="${{ steps.plugin-info.outputs.bundle_name }}"

TablePro/Core/Plugins/Registry/RegistryModels.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import Foundation
77

88
enum PluginArchitecture: String, Codable, Sendable {
99
case arm64
10-
case x86_64 = "x86_64"
10+
case x86_64
1111

1212
static var current: PluginArchitecture {
1313
#if arch(arm64)

docs/vi/development/plugin-registry.mdx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ Hai database driver này được phân phối dưới dạng plugin tải về
6262
"downloadURL": "https://github.com/datlechin/TablePro/releases/download/plugin-oracle-v1.0.0/OracleDriver-arm64.zip",
6363
"sha256": "<sha256-cua-zip>",
6464
"binaries": [
65-
{ "architecture": "arm64", "downloadURL": "https://github.com/datlechin/TablePro/releases/download/plugin-oracle-v1.0.0/OracleDriver-arm64.zip", "sha256": "<sha256-of-zip>" },
66-
{ "architecture": "x86_64", "downloadURL": "https://github.com/datlechin/TablePro/releases/download/plugin-oracle-v1.0.0/OracleDriver-x86_64.zip", "sha256": "<sha256-of-zip>" }
65+
{ "architecture": "arm64", "downloadURL": "https://github.com/datlechin/TablePro/releases/download/plugin-oracle-v1.0.0/OracleDriver-arm64.zip", "sha256": "<sha256-cua-zip>" },
66+
{ "architecture": "x86_64", "downloadURL": "https://github.com/datlechin/TablePro/releases/download/plugin-oracle-v1.0.0/OracleDriver-x86_64.zip", "sha256": "<sha256-cua-zip>" }
6767
],
6868
"minAppVersion": "0.17.0",
6969
"minPluginKitVersion": 1,
@@ -88,8 +88,8 @@ Hai database driver này được phân phối dưới dạng plugin tải về
8888
"downloadURL": "https://github.com/datlechin/TablePro/releases/download/plugin-clickhouse-v1.0.0/ClickHouseDriver-arm64.zip",
8989
"sha256": "<sha256-cua-zip>",
9090
"binaries": [
91-
{ "architecture": "arm64", "downloadURL": "https://github.com/datlechin/TablePro/releases/download/plugin-clickhouse-v1.0.0/ClickHouseDriver-arm64.zip", "sha256": "<sha256-of-zip>" },
92-
{ "architecture": "x86_64", "downloadURL": "https://github.com/datlechin/TablePro/releases/download/plugin-clickhouse-v1.0.0/ClickHouseDriver-x86_64.zip", "sha256": "<sha256-of-zip>" }
91+
{ "architecture": "arm64", "downloadURL": "https://github.com/datlechin/TablePro/releases/download/plugin-clickhouse-v1.0.0/ClickHouseDriver-arm64.zip", "sha256": "<sha256-cua-zip>" },
92+
{ "architecture": "x86_64", "downloadURL": "https://github.com/datlechin/TablePro/releases/download/plugin-clickhouse-v1.0.0/ClickHouseDriver-x86_64.zip", "sha256": "<sha256-cua-zip>" }
9393
],
9494
"minAppVersion": "0.17.0",
9595
"minPluginKitVersion": 1,

0 commit comments

Comments
 (0)