fix: address PR review feedback for column visibility

Author: datlechin

TablePro/Models/UI/ColumnVisibilityManager.swift

@@ -7,8 +7,8 @@ import Foundation
 import Observation
 
 @MainActor @Observable
-final class ColumnVisibilityManager {
-    var hiddenColumns: Set<String> = []
+internal final class ColumnVisibilityManager {
+    private(set) var hiddenColumns: Set<String> = []
 
     var hasHiddenColumns: Bool {
         !hiddenColumns.isEmpty
@@ -54,14 +54,14 @@ final class ColumnVisibilityManager {
 
     // MARK: - Per-Table UserDefaults Persistence
 
-    func saveLastHiddenColumns(for tableName: String) {
-        let key = "com.TablePro.columns.hiddenColumns.\(tableName)"
+    func saveLastHiddenColumns(for tableName: String, connectionId: UUID) {
+        let key = Self.userDefaultsKey(tableName: tableName, connectionId: connectionId)
         let array = Array(hiddenColumns)
         UserDefaults.standard.set(array, forKey: key)
     }
 
-    func restoreLastHiddenColumns(for tableName: String) {
-        let key = "com.TablePro.columns.hiddenColumns.\(tableName)"
+    func restoreLastHiddenColumns(for tableName: String, connectionId: UUID) {
+        let key = Self.userDefaultsKey(tableName: tableName, connectionId: connectionId)
         if let array = UserDefaults.standard.stringArray(forKey: key) {
             hiddenColumns = Set(array)
         } else {
@@ -74,4 +74,10 @@ final class ColumnVisibilityManager {
         let currentSet = Set(currentColumns)
         hiddenColumns = hiddenColumns.intersection(currentSet)
     }
+
+    // MARK: - Private
+
+    private static func userDefaultsKey(tableName: String, connectionId: UUID) -> String {
+        "com.TablePro.columns.hiddenColumns.\(connectionId.uuidString).\(tableName)"
+    }
 }

TablePro/Views/Main/Child/MainEditorContentView.swift

@@ -331,8 +331,8 @@ struct MainEditorContentView: View {
             tableName: tab.tableName,
             primaryKeyColumn: changeManager.primaryKeyColumn,
             hiddenColumns: columnVisibilityManager.hiddenColumns,
-            onHideColumn: { columnName in
-                columnVisibilityManager.hideColumn(columnName)
+            onHideColumn: { [coordinator] columnName in
+                coordinator.hideColumn(columnName)
             },
             selectedRowIndices: $selectedRowIndices,
             sortState: sortStateBinding(for: tab),

TablePro/Views/Main/Child/MainStatusBarView.swift

@@ -126,6 +126,9 @@ struct MainStatusBarView: View {
         .padding(.horizontal, 12)
         .padding(.vertical, 4)
         .background(Color(nsColor: .controlBackgroundColor))
+        .onChange(of: tab?.id) { _, _ in
+            showColumnPopover = false
+        }
     }
 
     /// Generate row info text based on selection and pagination state

TablePro/Views/Main/Extensions/MainContentCoordinator+ColumnVisibility.swift

@@ -19,11 +19,16 @@ extension MainContentCoordinator {
 
     /// Load per-table hidden columns from UserDefaults when opening a table tab
     func restoreLastHiddenColumnsForTable(_ tableName: String) {
-        columnVisibilityManager.restoreLastHiddenColumns(for: tableName)
+        columnVisibilityManager.restoreLastHiddenColumns(for: tableName, connectionId: connectionId)
     }
 
     /// Prune hidden columns that no longer exist in the current result set
     func pruneHiddenColumns(currentColumns: [String]) {
         columnVisibilityManager.pruneStaleColumns(currentColumns)
     }
+
+    /// Hide a single column (routed through coordinator for centralized control)
+    func hideColumn(_ columnName: String) {
+        columnVisibilityManager.hideColumn(columnName)
+    }
 }

TablePro/Views/Results/ColumnVisibilityPopover.swift

@@ -64,7 +64,7 @@ struct ColumnVisibilityPopover: View {
     }
 
     private var searchField: some View {
-        TextField("Search columns...", text: $searchText)
+        TextField(String(localized: "Search columns..."), text: $searchText)
             .textFieldStyle(.roundedBorder)
             .controlSize(.small)
             .padding(.horizontal, 12)

TablePro/Views/Results/DataGridView.swift

@@ -527,7 +527,10 @@ struct DataGridView: NSViewRepresentable {
             guard let colIndex = Self.columnIndex(from: column.identifier),
                   colIndex < rowProvider.columns.count else { continue }
             let columnName = rowProvider.columns[colIndex]
-            column.isHidden = hiddenColumns.contains(columnName)
+            let shouldHide = hiddenColumns.contains(columnName)
+            if column.isHidden != shouldHide {
+                column.isHidden = shouldHide
+            }
         }
     }
 

TableProTests/Models/UI/ColumnVisibilityManagerTests.swift

@@ -158,28 +158,30 @@ struct ColumnVisibilityManagerTests {
     @Test("UserDefaults round-trip for saveLastHiddenColumns and restoreLastHiddenColumns")
     func userDefaultsRoundTrip() {
         let tableName = "test_table_\(UUID().uuidString)"
-        let key = "com.TablePro.columns.hiddenColumns.\(tableName)"
+        let connectionId = UUID()
+        let key = "com.TablePro.columns.hiddenColumns.\(connectionId.uuidString).\(tableName)"
         defer { UserDefaults.standard.removeObject(forKey: key) }
 
         let manager = ColumnVisibilityManager()
         manager.hideAll(["col1", "col2", "col3"])
-        manager.saveLastHiddenColumns(for: tableName)
+        manager.saveLastHiddenColumns(for: tableName, connectionId: connectionId)
 
         let other = ColumnVisibilityManager()
-        other.restoreLastHiddenColumns(for: tableName)
+        other.restoreLastHiddenColumns(for: tableName, connectionId: connectionId)
         #expect(other.hiddenColumns == Set(["col1", "col2", "col3"]))
     }
 
     @Test("restoreLastHiddenColumns with no saved data resets to empty")
     func restoreWithNoSavedData() {
         let tableName = "nonexistent_table_\(UUID().uuidString)"
-        let key = "com.TablePro.columns.hiddenColumns.\(tableName)"
+        let connectionId = UUID()
+        let key = "com.TablePro.columns.hiddenColumns.\(connectionId.uuidString).\(tableName)"
         defer { UserDefaults.standard.removeObject(forKey: key) }
 
         let manager = ColumnVisibilityManager()
         manager.hideColumn("leftover")
 
-        manager.restoreLastHiddenColumns(for: tableName)
+        manager.restoreLastHiddenColumns(for: tableName, connectionId: connectionId)
         #expect(manager.hiddenColumns.isEmpty)
     }