feat: replace hardcoded DatabaseType switches with dynamic plugin metadata lookups (#305)

Author: datlechin

CHANGELOG.md

@@ -9,6 +9,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- Replaced ~40 hardcoded `DatabaseType` switches across ~20 UI files with dynamic plugin property lookups via `PluginManager`, so third-party plugins get correct UI behavior (colors, labels, editor language, feature toggles) automatically
+- Replaced `AppState.isMongoDB`/`isRedis` booleans with `AppState.editorLanguage: EditorLanguage` for extensible editor language detection
+- Theme colors now derived from plugin `brandColorHex` instead of hardcoded `Theme.mysqlColor` etc.
+- Sidebar labels ("Tables"/"Collections"/"Keys"), toolbar preview labels, and AI prompt language detection now use plugin metadata
+- Connection form, database switcher, type picker, file open handler, and toolbar all use plugin lookups for connection mode, authentication, import support, and system database names
 - Converted `DatabaseType` from closed enum to string-based struct, enabling future plugin-defined database types
 - Moved string literal escaping into plugin drivers via `escapeStringLiteral` on `PluginDatabaseDriver` and `DatabaseDriver` protocols; `SQLEscaping.escapeStringLiteral` now uses ANSI SQL escaping only (doubles single quotes, strips null bytes)
 - SQL autocomplete data types and CREATE TABLE options now use plugin-provided dialect data instead of hardcoded per-database switches

Plugins/MongoDBDriverPlugin/MongoDBPlugin.swift

@@ -53,6 +53,8 @@ final class MongoDBPlugin: NSObject, TableProPlugin, DriverPlugin {
     static let supportsForeignKeys = false
     static let supportsSchemaEditing = false
     static let systemDatabaseNames: [String] = ["admin", "local", "config"]
+    static let tableEntityName = "Collections"
+    static let supportsForeignKeyDisable = false
     static let databaseGroupingStrategy: GroupingStrategy = .flat
     static let columnTypesByCategory: [String: [String]] = [
         "String": ["string", "objectId", "regex"],

Plugins/OracleDriverPlugin/OraclePlugin.swift

@@ -23,6 +23,7 @@ final class OraclePlugin: NSObject, TableProPlugin, DriverPlugin {
 
     // MARK: - UI/Capability Metadata
 
+    static let supportsForeignKeyDisable = false
     static let brandColorHex = "#C3160B"
     static let systemDatabaseNames: [String] = ["SYS", "SYSTEM", "OUTLN", "DBSNMP", "APPQOSSYS", "WMSYS", "XDB"]
     static let databaseGroupingStrategy: GroupingStrategy = .bySchema

Plugins/PostgreSQLDriverPlugin/PostgreSQLPlugin.swift

@@ -47,6 +47,9 @@ final class PostgreSQLPlugin: NSObject, TableProPlugin, DriverPlugin {
         "XML": ["XML"]
     ]
 
+    static let supportsCascadeDrop = true
+    static let supportsForeignKeyDisable = false
+
     static let sqlDialect: SQLDialectDescriptor? = SQLDialectDescriptor(
         identifierQuote: "\"",
         keywords: [

Plugins/RedisDriverPlugin/RedisPlugin.swift

@@ -42,6 +42,8 @@ final class RedisPlugin: NSObject, TableProPlugin, DriverPlugin {
     static let supportsSchemaEditing = false
     static let supportsDatabaseSwitching = false
     static let supportsImport = false
+    static let tableEntityName = "Keys"
+    static let supportsForeignKeyDisable = false
     static let databaseGroupingStrategy: GroupingStrategy = .flat
     static let defaultGroupName = "db0"
     static let columnTypesByCategory: [String: [String]] = [

Plugins/TableProPluginKit/DriverPlugin.swift

@@ -36,6 +36,9 @@ public protocol DriverPlugin: TableProPlugin {
     static var columnTypesByCategory: [String: [String]] { get }
     static var sqlDialect: SQLDialectDescriptor? { get }
     static var statementCompletions: [CompletionEntry] { get }
+    static var tableEntityName: String { get }
+    static var supportsCascadeDrop: Bool { get }
+    static var supportsForeignKeyDisable: Bool { get }
 }
 
 public extension DriverPlugin {
@@ -76,4 +79,7 @@ public extension DriverPlugin {
     }
     static var sqlDialect: SQLDialectDescriptor? { nil }
     static var statementCompletions: [CompletionEntry] { [] }
+    static var tableEntityName: String { "Tables" }
+    static var supportsCascadeDrop: Bool { false }
+    static var supportsForeignKeyDisable: Bool { true }
 }

TablePro/AppDelegate+FileOpen.swift

@@ -14,32 +14,21 @@ private let fileOpenLogger = Logger(subsystem: "com.TablePro", category: "FileOp
 extension AppDelegate {
     // MARK: - URL Classification
 
-    private static let databaseURLSchemes: Set<String> = [
-        "postgresql", "postgres", "mysql", "mariadb", "sqlite",
-        "mongodb", "mongodb+srv", "redis", "rediss", "redshift",
-        "mssql", "sqlserver", "oracle", "duckdb"
-    ]
-
-    static let sqliteFileExtensions: Set<String> = [
-        "sqlite", "sqlite3", "db3", "s3db", "sl3", "sqlitedb"
-    ]
-
-    static let duckdbFileExtensions: Set<String> = ["duckdb", "ddb"]
-
     private func isDatabaseURL(_ url: URL) -> Bool {
         guard let scheme = url.scheme?.lowercased() else { return false }
         let base = scheme
             .replacingOccurrences(of: "+ssh", with: "")
             .replacingOccurrences(of: "+srv", with: "")
-        return Self.databaseURLSchemes.contains(base) || Self.databaseURLSchemes.contains(scheme)
+        let registeredSchemes = PluginManager.shared.allRegisteredURLSchemes
+        return registeredSchemes.contains(base) || registeredSchemes.contains(scheme)
     }
 
-    private func isSQLiteFile(_ url: URL) -> Bool {
-        Self.sqliteFileExtensions.contains(url.pathExtension.lowercased())
+    private func isDatabaseFile(_ url: URL) -> Bool {
+        PluginManager.shared.allRegisteredFileExtensions[url.pathExtension.lowercased()] != nil
     }
 
-    private func isDuckDBFile(_ url: URL) -> Bool {
-        Self.duckdbFileExtensions.contains(url.pathExtension.lowercased())
+    private func databaseTypeForFile(_ url: URL) -> DatabaseType? {
+        PluginManager.shared.allRegisteredFileExtensions[url.pathExtension.lowercased()]
     }
 
     // MARK: - Main Dispatch
@@ -68,20 +57,21 @@ extension AppDelegate {
             }
         }
 
-        let sqliteFiles = urls.filter { isSQLiteFile($0) }
-        if !sqliteFiles.isEmpty {
-            suppressWelcomeWindow()
-            Task { @MainActor in
-                for url in sqliteFiles { self.handleSQLiteFile(url) }
-                self.scheduleWelcomeWindowSuppression()
-            }
-        }
-
-        let duckdbFiles = urls.filter { isDuckDBFile($0) }
-        if !duckdbFiles.isEmpty {
+        let databaseFiles = urls.filter { isDatabaseFile($0) }
+        if !databaseFiles.isEmpty {
             suppressWelcomeWindow()
             Task { @MainActor in
-                for url in duckdbFiles { self.handleDuckDBFile(url) }
+                for url in databaseFiles {
+                    guard let dbType = self.databaseTypeForFile(url) else { continue }
+                    switch dbType {
+                    case .sqlite:
+                        self.handleSQLiteFile(url)
+                    case .duckdb:
+                        self.handleDuckDBFile(url)
+                    default:
+                        break
+                    }
+                }
                 self.scheduleWelcomeWindowSuppression()
             }
         }

TablePro/ContentView.swift

@@ -8,6 +8,7 @@
 import AppKit
 import os
 import SwiftUI
+import TableProPluginKit
 
 struct ContentView: View {
     private static let logger = Logger(subsystem: "com.TablePro", category: "ContentView")
@@ -40,11 +41,8 @@ struct ContentView: View {
             defaultTitle = tableName
         } else if let connectionId = payload?.connectionId,
                   let connection = ConnectionStorage.shared.loadConnections().first(where: { $0.id == connectionId }) {
-            switch connection.type {
-            case .mongodb: defaultTitle = "MQL Query"
-            case .redis: defaultTitle = "Redis CLI"
-            default: defaultTitle = "SQL Query"
-            }
+            let langName = PluginManager.shared.queryLanguageName(for: connection.type)
+            defaultTitle = langName == "SQL" ? "SQL Query" : langName == "MQL" ? "MQL Query" : langName
         } else {
             defaultTitle = "SQL Query"
         }
@@ -94,8 +92,9 @@ struct ContentView: View {
                         }
                         AppState.shared.isConnected = true
                         AppState.shared.safeModeLevel = session.connection.safeModeLevel
-                        AppState.shared.isMongoDB = session.connection.type == .mongodb
-                        AppState.shared.isRedis = session.connection.type == .redis
+                        AppState.shared.editorLanguage = PluginManager.shared.editorLanguage(for: session.connection.type)
+                        AppState.shared.supportsDatabaseSwitching = PluginManager.shared.supportsDatabaseSwitching(
+                            for: session.connection.type)
                     }
                 } else {
                     currentSession = nil
@@ -119,8 +118,8 @@ struct ContentView: View {
                         columnVisibility = .detailOnly
                         AppState.shared.isConnected = false
                         AppState.shared.safeModeLevel = .silent
-                        AppState.shared.isMongoDB = false
-                        AppState.shared.isRedis = false
+                        AppState.shared.editorLanguage = .sql
+                        AppState.shared.supportsDatabaseSwitching = true
 
                         // Close all native tab windows for this connection and
                         // force AppKit to deallocate them instead of pooling.
@@ -150,8 +149,9 @@ struct ContentView: View {
                 }
                 AppState.shared.isConnected = true
                 AppState.shared.safeModeLevel = newSession.connection.safeModeLevel
-                AppState.shared.isMongoDB = newSession.connection.type == .mongodb
-                AppState.shared.isRedis = newSession.connection.type == .redis
+                AppState.shared.editorLanguage = PluginManager.shared.editorLanguage(for: newSession.connection.type)
+                AppState.shared.supportsDatabaseSwitching = PluginManager.shared.supportsDatabaseSwitching(
+                    for: newSession.connection.type)
             }
             .onReceive(NotificationCenter.default.publisher(for: NSWindow.didBecomeKeyNotification)) { notification in
                 // Only process notifications for our own window to avoid every
@@ -178,13 +178,14 @@ struct ContentView: View {
                 if let session = DatabaseManager.shared.activeSessions[connectionId] {
                     AppState.shared.isConnected = true
                     AppState.shared.safeModeLevel = session.connection.safeModeLevel
-                    AppState.shared.isMongoDB = session.connection.type == .mongodb
-                    AppState.shared.isRedis = session.connection.type == .redis
+                    AppState.shared.editorLanguage = PluginManager.shared.editorLanguage(for: session.connection.type)
+                    AppState.shared.supportsDatabaseSwitching = PluginManager.shared.supportsDatabaseSwitching(
+                        for: session.connection.type)
                 } else {
                     AppState.shared.isConnected = false
                     AppState.shared.safeModeLevel = .silent
-                    AppState.shared.isMongoDB = false
-                    AppState.shared.isRedis = false
+                    AppState.shared.editorLanguage = .sql
+                    AppState.shared.supportsDatabaseSwitching = true
                 }
             }
     }

TablePro/Core/AI/AIPromptTemplates.swift

@@ -10,31 +10,26 @@ import Foundation
 /// Centralized prompt templates for AI-powered editor features
 enum AIPromptTemplates {
     /// Build a prompt asking AI to explain a query
-    static func explainQuery(_ query: String, databaseType: DatabaseType = .mysql) -> String {
+    @MainActor static func explainQuery(_ query: String, databaseType: DatabaseType = .mysql) -> String {
         let (typeName, lang) = queryInfo(for: databaseType)
         return "Explain this \(typeName):\n\n```\(lang)\n\(query)\n```"
     }
 
     /// Build a prompt asking AI to optimize a query
-    static func optimizeQuery(_ query: String, databaseType: DatabaseType = .mysql) -> String {
+    @MainActor static func optimizeQuery(_ query: String, databaseType: DatabaseType = .mysql) -> String {
         let (typeName, lang) = queryInfo(for: databaseType)
         return "Optimize this \(typeName) for better performance:\n\n```\(lang)\n\(query)\n```"
     }
 
     /// Build a prompt asking AI to fix a query that produced an error
-    static func fixError(query: String, error: String, databaseType: DatabaseType = .mysql) -> String {
+    @MainActor static func fixError(query: String, error: String, databaseType: DatabaseType = .mysql) -> String {
         let (typeName, lang) = queryInfo(for: databaseType)
         return "This \(typeName) failed with an error. Please fix it.\n\nQuery:\n```\(lang)\n\(query)\n```\n\nError: \(error)"
     }
 
-    private static func queryInfo(for databaseType: DatabaseType) -> (typeName: String, language: String) {
-        switch databaseType {
-        case .mongodb:
-            return ("MongoDB query", "javascript")
-        case .redis:
-            return ("Redis command", "bash")
-        default:
-            return ("SQL query", "sql")
-        }
+    @MainActor private static func queryInfo(for databaseType: DatabaseType) -> (typeName: String, language: String) {
+        let langName = PluginManager.shared.queryLanguageName(for: databaseType)
+        let lang = PluginManager.shared.editorLanguage(for: databaseType).codeBlockTag
+        return ("\(langName) query", lang)
     }
 }

TablePro/Core/AI/AISchemaContext.swift

@@ -7,6 +7,7 @@
 
 import Foundation
 import os
+import TableProPluginKit
 
 /// Builds schema context for AI system prompts
 struct AISchemaContext {
@@ -18,7 +19,7 @@ struct AISchemaContext {
     // MARK: - Public
 
     /// Build a system prompt including database context
-    static func buildSystemPrompt(
+    @MainActor static func buildSystemPrompt(
         databaseType: DatabaseType,
         databaseName: String,
         tables: [TableInfo],
@@ -55,12 +56,7 @@ struct AISchemaContext {
         if settings.includeCurrentQuery,
            let query = currentQuery,
            !query.isEmpty {
-            let lang: String
-            switch databaseType {
-            case .mongodb: lang = "javascript"
-            case .redis: lang = "bash"
-            default: lang = "sql"
-            }
+            let lang = PluginManager.shared.editorLanguage(for: databaseType).codeBlockTag
             parts.append("\n## Current Query\n```\(lang)\n\(query)\n```")
         }
 
@@ -70,21 +66,12 @@ struct AISchemaContext {
             parts.append("\n## Recent Query Results\n\(results)")
         }
 
-        if databaseType == .mongodb {
-            parts.append(
-                "\nProvide MongoDB shell queries using `javascript` fenced code blocks."
-            )
-            parts.append(
-                "Use MongoDB shell syntax (db.collection.find(), etc.), not SQL."
-            )
-        } else if databaseType == .redis {
-            parts.append(
-                "\nProvide Redis commands using `bash` fenced code blocks."
-            )
-            parts.append(
-                "Use Redis CLI syntax (GET, SET, HGETALL, etc.), not SQL."
-            )
-        } else {
+        let editorLang = PluginManager.shared.editorLanguage(for: databaseType)
+        let langName = PluginManager.shared.queryLanguageName(for: databaseType)
+        let langTag = editorLang.codeBlockTag
+
+        switch editorLang {
+        case .sql:
             parts.append(
                 "\nProvide SQL queries appropriate for"
                 + " \(databaseType.rawValue) syntax when applicable."
@@ -93,6 +80,13 @@ struct AISchemaContext {
                 "When writing SQL, use the correct identifier quoting"
                 + " for \(databaseType.rawValue)."
             )
+        default:
+            parts.append(
+                "\nProvide \(langName) queries using `\(langTag)` fenced code blocks."
+            )
+            parts.append(
+                "Use \(langName) syntax, not SQL."
+            )
         }
 
         return parts.joined(separator: "\n")