fix: correct window management and event handling patterns

- VIEW-1.1 (high): replace title-matching window discovery with WindowAccessor NSViewRepresentable
- VIEW-1.2 (high): replace all NSApp.keyWindow (22 occurrences) with coordinator.window
- VIEW-8.2 (medium): extract onAppear into coordinator.configureWindow/registerWindowLifecycle
- VIEW-6.1 (high): replace NSEvent.addLocalMonitorForEvents with .onKeyPress in ConnectionSwitcherPopover
- APP-2.3 (high): remove openWindow from WindowOpener singleton, use NotificationCenter
- MODEL-1.2 (high): simplify QueryTab equality to id-based, add contentHash for change detection
- MODEL-1.8 (medium): replace UUID() on ColumnInfo/IndexInfo/ForeignKeyInfo with deterministic ids

Author: datlechin

TablePro/AppDelegate+ConnectionHandler.swift

@@ -23,7 +23,7 @@ extension AppDelegate {
     // MARK: - Database URL Handler
 
     func handleDatabaseURL(_ url: URL) {
-        guard WindowOpener.shared.openWindow != nil else {
+        guard WindowOpener.shared.isReady else {
             queuedURLEntries.append(.databaseURL(url))
             scheduleQueuedURLProcessing()
             return
@@ -86,7 +86,7 @@ extension AppDelegate {
     // MARK: - SQLite File Handler
 
     func handleSQLiteFile(_ url: URL) {
-        guard WindowOpener.shared.openWindow != nil else {
+        guard WindowOpener.shared.isReady else {
             queuedURLEntries.append(.sqliteFile(url))
             scheduleQueuedURLProcessing()
             return
@@ -131,7 +131,7 @@ extension AppDelegate {
     // MARK: - DuckDB File Handler
 
     func handleDuckDBFile(_ url: URL) {
-        guard WindowOpener.shared.openWindow != nil else {
+        guard WindowOpener.shared.isReady else {
             queuedURLEntries.append(.duckdbFile(url))
             scheduleQueuedURLProcessing()
             return
@@ -176,7 +176,7 @@ extension AppDelegate {
     // MARK: - Generic Database File Handler
 
     func handleGenericDatabaseFile(_ url: URL, type dbType: DatabaseType) {
-        guard WindowOpener.shared.openWindow != nil else {
+        guard WindowOpener.shared.isReady else {
             queuedURLEntries.append(.genericDatabaseFile(url, dbType))
             scheduleQueuedURLProcessing()
             return
@@ -229,7 +229,7 @@ extension AppDelegate {
 
             var ready = false
             for _ in 0..<25 {
-                if WindowOpener.shared.openWindow != nil { ready = true; break }
+                if WindowOpener.shared.isReady { ready = true; break }
                 try? await Task.sleep(for: .milliseconds(200))
             }
             guard let self else { return }

TablePro/AppDelegate+FileOpen.swift

@@ -193,9 +193,7 @@ extension AppDelegate {
         ConnectionStorage.shared.addConnection(connection)
         NotificationCenter.default.post(name: .connectionUpdated, object: nil)
 
-        if let openWindow = WindowOpener.shared.openWindow {
-            openWindow(id: "connection-form", value: connection.id)
-        }
+        NotificationCenter.default.post(name: .openConnectionFormWindow, object: connection.id)
     }
 
     // MARK: - Plugin Install

TablePro/Core/SchemaTracking/StructureChangeManager.swift

@@ -78,7 +78,7 @@ final class StructureChangeManager {
         self.currentForeignKeys = groupedFKs.keys.sorted().compactMap { name -> EditableForeignKeyDefinition? in
             guard let fkInfos = groupedFKs[name], let first = fkInfos.first else { return nil }
             return EditableForeignKeyDefinition(
-                id: first.id,
+                id: UUID(),
                 name: first.name,
                 columns: fkInfos.map { $0.column },
                 referencedTable: first.referencedTable,

TablePro/Core/Services/Infrastructure/WindowOpener.swift

@@ -15,23 +15,20 @@ internal final class WindowOpener {
 
     internal static let shared = WindowOpener()
 
-    /// Set by ContentView when it appears. Safe to store — OpenWindowAction is app-scoped, not view-scoped.
-    internal var openWindow: OpenWindowAction?
+    /// True once any SwiftUI scene has appeared and stored `openWindow`.
+    /// Used as a readiness check by AppDelegate cold-start queue.
+    internal var isReady: Bool = false
 
     /// The connectionId for the next window about to be opened.
     /// Set by `openNativeTab` before calling `openWindow`, consumed by
     /// `AppDelegate.windowDidBecomeKey` to set the correct `tabbingIdentifier`.
     internal var pendingConnectionId: UUID?
 
-    /// Opens a new native window tab with the given payload.
-    /// Stores the connectionId so AppDelegate can set the correct tabbingIdentifier.
+    /// Opens a new native window tab by posting a notification.
+    /// The `OpenWindowHandler` in TableProApp receives it and calls `openWindow`.
     internal func openNativeTab(_ payload: EditorTabPayload) {
         pendingConnectionId = payload.connectionId
-        guard let openWindow else {
-            Self.logger.warning("openNativeTab called before openWindow was set — payload dropped")
-            return
-        }
-        openWindow(id: "main", value: payload)
+        NotificationCenter.default.post(name: .openMainWindow, object: payload)
     }
 
     /// Returns and clears the pending connectionId (consume-once pattern).

TablePro/Models/Query/QueryResult.swift

@@ -113,7 +113,7 @@ struct TableInfo: Identifiable, Hashable {
 
 /// Information about a table column
 struct ColumnInfo: Identifiable, Hashable {
-    let id = UUID()
+    var id: String { name }
     let name: String
     let dataType: String
     let isNullable: Bool
@@ -127,7 +127,7 @@ struct ColumnInfo: Identifiable, Hashable {
 
 /// Information about a table index
 struct IndexInfo: Identifiable, Hashable {
-    let id = UUID()
+    var id: String { "\(name)_\(columns.joined(separator: ","))" }
     let name: String
     let columns: [String]
     let isUnique: Bool
@@ -137,7 +137,7 @@ struct IndexInfo: Identifiable, Hashable {
 
 /// Information about a foreign key relationship
 struct ForeignKeyInfo: Identifiable, Hashable {
-    let id = UUID()
+    var id: String { "\(column)_\(referencedTable)_\(referencedColumn)" }
     let name: String
     let column: String
     let referencedTable: String

TablePro/Models/Query/QueryTab.swift

@@ -279,7 +279,10 @@ struct QueryTab: Identifiable, Equatable {
     var tabType: TabType
 
     // Results — stored in a reference-type buffer to avoid CoW duplication
-    // of large data when the struct is mutated (MEM-1 fix)
+    // of large data when the struct is mutated (MEM-1 fix).
+    // Note: When QueryTab is copied (struct CoW), copies share the same RowBuffer
+    // instance. This is intentional — RowBuffer is a reference type specifically to
+    // avoid duplicating large result arrays on every struct mutation.
     var rowBuffer: RowBuffer
 
     // Backward-compatible computed accessors for result data
@@ -492,22 +495,35 @@ struct QueryTab: Identifiable, Equatable {
         )
     }
 
+    // Identity-based equality: two QueryTabs are equal if they represent the same tab.
+    // Content changes (query text, results, filters, etc.) are tracked via resultVersion,
+    // metadataVersion, and SwiftUI's observation system — not via Equatable.
     static func == (lhs: QueryTab, rhs: QueryTab) -> Bool {
         lhs.id == rhs.id
-            && lhs.title == rhs.title
-            && lhs.isExecuting == rhs.isExecuting
-            && lhs.errorMessage == rhs.errorMessage
-            && lhs.executionTime == rhs.executionTime
-            && lhs.resultVersion == rhs.resultVersion
-            && lhs.pagination == rhs.pagination
-            && lhs.sortState == rhs.sortState
-            && lhs.showStructure == rhs.showStructure
-            && lhs.isEditable == rhs.isEditable
-            && lhs.isView == rhs.isView
-            && lhs.tabType == rhs.tabType
-            && lhs.rowsAffected == rhs.rowsAffected
-            && lhs.isPreview == rhs.isPreview
-            && lhs.hasUserInteraction == rhs.hasUserInteraction
+    }
+
+    /// Hash of content fields that matter for change detection.
+    /// Use this when you need to know if a tab's visible state has changed
+    /// (e.g., for caching or diff purposes), rather than relying on Equatable.
+    var contentHash: Int {
+        var hasher = Hasher()
+        hasher.combine(id)
+        hasher.combine(title)
+        hasher.combine(query)
+        hasher.combine(tableName)
+        hasher.combine(isExecuting)
+        hasher.combine(errorMessage)
+        hasher.combine(executionTime)
+        hasher.combine(resultVersion)
+        hasher.combine(metadataVersion)
+        hasher.combine(showStructure)
+        hasher.combine(isEditable)
+        hasher.combine(isView)
+        hasher.combine(tabType)
+        hasher.combine(rowsAffected)
+        hasher.combine(isPreview)
+        hasher.combine(hasUserInteraction)
+        return hasher.finalize()
     }
 }
 

TablePro/Models/Schema/ColumnDefinition.swift

@@ -52,7 +52,7 @@ struct EditableColumnDefinition: Hashable, Codable, Identifiable {
     /// Create from existing ColumnInfo
     static func from(_ columnInfo: ColumnInfo) -> EditableColumnDefinition {
         EditableColumnDefinition(
-            id: columnInfo.id,
+            id: UUID(),
             name: columnInfo.name,
             dataType: columnInfo.dataType,
             isNullable: columnInfo.isNullable,

TablePro/Models/Schema/ForeignKeyDefinition.swift

@@ -49,7 +49,7 @@ struct EditableForeignKeyDefinition: Hashable, Codable, Identifiable {
     /// Create from existing ForeignKeyInfo
     static func from(_ fkInfo: ForeignKeyInfo) -> EditableForeignKeyDefinition {
         EditableForeignKeyDefinition(
-            id: fkInfo.id,
+            id: UUID(),
             name: fkInfo.name,
             columns: [fkInfo.column],
             referencedTable: fkInfo.referencedTable,

TablePro/Models/Schema/IndexDefinition.swift

@@ -49,7 +49,7 @@ struct EditableIndexDefinition: Hashable, Codable, Identifiable {
     /// Create from existing IndexInfo
     static func from(_ indexInfo: IndexInfo) -> EditableIndexDefinition {
         EditableIndexDefinition(
-            id: indexInfo.id,
+            id: UUID(),
             name: indexInfo.name,
             columns: indexInfo.columns,
             type: IndexType(rawValue: indexInfo.type.uppercased()) ?? .btree,