fix: address CodeRabbit review comments

- Use consistent user-facing identifier in pluginNotLoaded error
- Add explicit internal access to EmptyDialect
- Replace DispatchQueue.main.async with MainActor.run in HostKeyVerifier
- Log settings decode errors instead of silently swallowing with try?

Author: datlechin

TablePro/Core/Database/DatabaseDriver.swift

@@ -321,7 +321,7 @@ enum DatabaseDriverFactory {
             // If background loading hasn't finished yet, throw a specific error
             // instead of blocking the main thread with synchronous plugin loading.
             if !PluginManager.shared.hasFinishedInitialLoad {
-                throw PluginError.pluginNotLoaded(pluginId)
+                throw PluginError.pluginNotLoaded(connection.type.rawValue)
             }
             if connection.type.isDownloadablePlugin {
                 throw PluginError.pluginNotInstalled(connection.type.rawValue)

TablePro/Core/SSH/HostKeyVerifier.swift

@@ -101,18 +101,16 @@ internal enum HostKeyVerifier {
             Are you sure you want to continue connecting?
             """)
 
-        return await withCheckedContinuation { continuation in
-            DispatchQueue.main.async {
-                let alert = NSAlert()
-                alert.messageText = title
-                alert.informativeText = message
-                alert.alertStyle = .informational
-                alert.addButton(withTitle: String(localized: "Trust"))
-                alert.addButton(withTitle: String(localized: "Cancel"))
-
-                let response = alert.runModal()
-                continuation.resume(returning: response == .alertFirstButtonReturn)
-            }
+        return await MainActor.run {
+            let alert = NSAlert()
+            alert.messageText = title
+            alert.informativeText = message
+            alert.alertStyle = .informational
+            alert.addButton(withTitle: String(localized: "Trust"))
+            alert.addButton(withTitle: String(localized: "Cancel"))
+
+            let response = alert.runModal()
+            return response == .alertFirstButtonReturn
         }
     }
 
@@ -135,22 +133,20 @@ internal enum HostKeyVerifier {
             Current fingerprint: \(actual)
             """)
 
-        return await withCheckedContinuation { continuation in
-            DispatchQueue.main.async {
-                let alert = NSAlert()
-                alert.messageText = title
-                alert.informativeText = message
-                alert.alertStyle = .critical
-                alert.addButton(withTitle: String(localized: "Connect Anyway"))
-                alert.addButton(withTitle: String(localized: "Disconnect"))
-
-                // Make "Disconnect" the default button (Return key) instead of "Connect Anyway"
-                alert.buttons[1].keyEquivalent = "\r"
-                alert.buttons[0].keyEquivalent = ""
-
-                let response = alert.runModal()
-                continuation.resume(returning: response == .alertFirstButtonReturn)
-            }
+        return await MainActor.run {
+            let alert = NSAlert()
+            alert.messageText = title
+            alert.informativeText = message
+            alert.alertStyle = .critical
+            alert.addButton(withTitle: String(localized: "Connect Anyway"))
+            alert.addButton(withTitle: String(localized: "Disconnect"))
+
+            // Make "Disconnect" the default button (Return key) instead of "Connect Anyway"
+            alert.buttons[1].keyEquivalent = "\r"
+            alert.buttons[0].keyEquivalent = ""
+
+            let response = alert.runModal()
+            return response == .alertFirstButtonReturn
         }
     }
 }

TablePro/Core/Services/Query/SQLDialectProvider.swift

@@ -28,7 +28,7 @@ struct PluginDialectAdapter: SQLDialectProvider {
 
 /// Fallback dialect with no keywords/functions. Internal visibility so SQLFormatterService
 /// can use it as a fallback when resolving dialects off the main thread.
-struct EmptyDialect: SQLDialectProvider {
+internal struct EmptyDialect: SQLDialectProvider {
     let identifierQuote = "\""
     let keywords: Set<String> = []
     let functions: Set<String> = []

TablePro/Core/Sync/SyncCoordinator.swift

@@ -565,40 +565,25 @@ final class SyncCoordinator {
               let data = SyncRecordMapper.settingsData(from: record)
         else { return }
 
-        let decoder = JSONDecoder()
-        switch category {
-        case "general":
-            if let settings = try? decoder.decode(GeneralSettings.self, from: data) {
-                AppSettingsStorage.shared.saveGeneral(settings)
-            }
-        case "appearance":
-            if let settings = try? decoder.decode(AppearanceSettings.self, from: data) {
-                AppSettingsStorage.shared.saveAppearance(settings)
-            }
-        case "editor":
-            if let settings = try? decoder.decode(EditorSettings.self, from: data) {
-                AppSettingsStorage.shared.saveEditor(settings)
-            }
-        case "dataGrid":
-            if let settings = try? decoder.decode(DataGridSettings.self, from: data) {
-                AppSettingsStorage.shared.saveDataGrid(settings)
-            }
-        case "history":
-            if let settings = try? decoder.decode(HistorySettings.self, from: data) {
-                AppSettingsStorage.shared.saveHistory(settings)
-            }
-        case "tabs":
-            if let settings = try? decoder.decode(TabSettings.self, from: data) {
-                AppSettingsStorage.shared.saveTabs(settings)
-            }
-        case "keyboard":
-            if let settings = try? decoder.decode(KeyboardSettings.self, from: data) {
-                AppSettingsStorage.shared.saveKeyboard(settings)
-            }
-        case "ai":
-            if let settings = try? decoder.decode(AISettings.self, from: data) {
-                AppSettingsStorage.shared.saveAI(settings)
+        func decode<T: Decodable>(_ type: T.Type, save: (T) -> Void) {
+            do {
+                let settings = try JSONDecoder().decode(type, from: data)
+                save(settings)
+            } catch {
+                logger.debug("Failed to decode remote settings '\(category)': \(error.localizedDescription)")
             }
+        }
+
+        let storage = AppSettingsStorage.shared
+        switch category {
+        case "general": decode(GeneralSettings.self, save: storage.saveGeneral)
+        case "appearance": decode(AppearanceSettings.self, save: storage.saveAppearance)
+        case "editor": decode(EditorSettings.self, save: storage.saveEditor)
+        case "dataGrid": decode(DataGridSettings.self, save: storage.saveDataGrid)
+        case "history": decode(HistorySettings.self, save: storage.saveHistory)
+        case "tabs": decode(TabSettings.self, save: storage.saveTabs)
+        case "keyboard": decode(KeyboardSettings.self, save: storage.saveKeyboard)
+        case "ai": decode(AISettings.self, save: storage.saveAI)
         default:
             break
         }