fix: clean up leaked observers, untracked tasks, and misleading log#218
Merged
fix: clean up leaked observers, untracked tasks, and misleading log#218
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #217. Full resource cleanup audit found 3 additional issues:
setupURLNotificationObservers()registered two block-basedNotificationCenterobservers but never stored the returnedNSObjectProtocoltokens. Each window open/close accumulated 2 orphaned observers. Now stores tokens and removes them inteardown().connectToSession()andreconnectSession()spawned fire-and-forgetTask {}blocks to create metadata drivers that were never stored or cancelled. IfdisconnectSession()ran before completion, the task could assign a driver to a stale session. Now tracked inmetadataCreationTasksand cancelled on disconnect.ConnectionHealthMonitorretries indefinitely with exponential backoff. Fixed the message.Also adds
docs/development/resource-cleanup-audit.mdtracking all findings from the audit.Closes #214
Test plan