feat: bundle ClickHouse, MSSQL, Redis, XLSX, MQL, SQLImport as built-in#445
feat: bundle ClickHouse, MSSQL, Redis, XLSX, MQL, SQLImport as built-in#445
Conversation
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughPlugin distribution model updated to move several plugins from registry-distributed to built-in status. Build configuration extended to include additional plugin bundles in the app copy phase. Plugin manager enhanced to detect and remove user-installed plugins with bundle identifiers matching built-in plugins. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
PluginManagerto auto-remove user-installed copies that now ship built-inDetails
pbxproj changes: Added
PBXBuildFile,PBXContainerItemProxy,PBXTargetDependencyentries for each plugin and added them to the "Copy Plug-Ins" build phase.Migration: Users who previously installed these via the registry will have their user-installed copies automatically deleted on next launch (
removeUserInstalledDuplicates). The existing shadowing logic (skip user plugin if built-in has same bundle ID) serves as a fallback if deletion fails.Remaining registry plugins: MongoDB (heavy libmongoc), Oracle (OracleNIO SPM), DuckDB (50-100MB libduckdb), Cassandra, Etcd, CloudflareD1.
Test plan
TablePro.app/Contents/PlugIns/~/Library/Application Support/TablePro/Plugins/, launch app, verify it gets auto-removedSummary by CodeRabbit
New Features
Improvements
Documentation