Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/app/,/users/,(root))get,put,del,watch,lease,member,endpoint,auth,user,rolecommands with flagsQueryTab.buildBaseTableQueryto use plugin'sbuildBrowseQuerywhen available, so NoSQL plugins get table-specific initial queries instead of hardcoded SCAN commandsDispatchQueue.syncmissingexecute:label in SSH tunnel codeCloses #339
Test plan
docker run -d --name etcd -p 2379:2379 -e ALLOW_NONE_AUTHENTICATION=yes quay.io/coreos/etcd:v3.5.0 /usr/local/bin/etcd --advertise-client-urls http://0.0.0.0:2379 --listen-client-urls http://0.0.0.0:2379etcdctl --endpoints=http://127.0.0.1:2379 put /app/config/db_host localhost(and more keys)127.0.0.1, port2379, no auth, TLS disabled/app/,/users/,(root))get /app/config/db_host,member list,endpoint status,lease listSummary by CodeRabbit
New Features
Tests
Chores
Documentation