[ENHANCEMENT] Performance tweaking with buffered query cursor - not be applied on heavy queries (memory issues)

Author: tacoor

lib/addon/creole/drivers/sfDebugConnection.php

@@ -178,6 +178,35 @@ public function executeQuery($sql, $fetchmode = null)
     return $retval;
   }
 
+  /**
+   * @see Connection::executeQuery()
+   */
+  public function executeQueryBuffered($sql, $fetchmode = null)
+  {
+    $this->lastExecutedQuery = $sql;
+    $this->numQueriesExecuted++;
+
+    $elapsedTime = 0;
+    if (sfConfig::get('sf_debug') && sfConfig::get('sf_logging_enabled'))
+    {
+      $sqlTimer = sfTimerManager::getTimer('Database');
+      $timer = new sfTimer();
+    }
+
+    $retval = $this->childConnection->executeQueryBuffered($sql, $fetchmode);
+
+    if (sfConfig::get('sf_debug') && sfConfig::get('sf_logging_enabled'))
+    {
+      $sqlTimer->addTime();
+      $elapsedTime = $timer->getElapsedTime();
+    }
+
+    $this->log(sprintf("{sfCreole} executeQuery(): [%.2f ms] %s", $elapsedTime * 1000, $sql));
+
+    return $retval;
+  }
+
+
   /**
   * @see Connection::executeUpdate()
   **/

lib/vendor/creole/drivers/mssqlsrv/MSSQLSRVConnection.php

@@ -168,6 +168,29 @@ function executeQuery($sql, $fetchmode = null)
     return new MSSQLSRVResultSet($this, $result, $fetchmode);
   }
 
+  /**
+   * @see Connection::executeQuery()
+   */
+  function executeQueryBuffered($sql, $fetchmode = null)
+  {
+    $this->lastQuery = $sql;
+
+    $result = sqlsrv_query($this->dblink, $sql, null, array("Scrollable" => SQLSRV_CURSOR_CLIENT_BUFFERED));
+    if($result === false)
+    {
+      throw new SQLException('Could not execute query: ' . $sql,  $this->sqlError());
+    }
+
+    // get first results with has fields
+    $numfields = sqlsrv_num_fields( $result );
+    while(($numfields == false)&&(sqlsrv_num_fields( $result )))
+    {
+      $numfields = sqlsrv_fetch_array( $result );
+    }
+
+    return new MSSQLSRVResultSet($this, $result, $fetchmode);
+  }
+  
   /**
    * @see Connection::executeUpdate()
    */

lib/vendor/creole/drivers/mssqlsrv/MSSQLSRVPreparedStatement.php

@@ -33,18 +33,18 @@ class MSSQLSRVPreparedStatement extends PreparedStatementCommon implements Prepa
 
     /**
      * @inheritdoc
-     * 
+     *
      */
     public function __construct(Connection $conn, $sql)
     {
       if (false !== stripos($sql, 'insert into'))
       {
         $sql .= '; SELECT SCOPE_IDENTITY() AS ID';
       }
-      
+
       parent::__construct($conn, $sql);
     }
-    
+
     /**
      * Add quotes using str_replace.
      * This is not as thorough as MySQL.
@@ -90,7 +90,14 @@ public function executeQuery($p1 = null, $fetchmode = null)
           }
         }
 
-        $this->resultSet = $this->conn->executeQuery($sql, $fetchmode);
+        if($this->limit)
+        {
+          $this->resultSet = $this->conn->executeQueryBuffered($sql, $fetchmode);
+        }
+        else
+        {
+          $this->resultSet = $this->conn->executeQuery($sql, $fetchmode);
+        }
 
         if(!$offsetBefore)
         {