handle non array coming back from secrets manager

swilla · swilla · commit d2cd89911664 · 2020-07-24T15:55:48.000-04:00
diff --git a/src/LaravelAwsSecretsManager.php b/src/LaravelAwsSecretsManager.php
@@ -113,9 +113,12 @@ protected function getVariables()
                         'SecretId' => $item['ARN'],
                     ]);
 
-                    foreach (json_decode($result['SecretString'], true) as $key => $secret) {
-                        putenv("$key=$secret");
-                        $this->storeToCache($key, $secret);
+                    $secretValues = json_decode($result['SecretString'], true);
+                    if (is_array($secretValues)) {
+                        foreach ($secretValues as $key => $secret) {
+                            putenv("$key=$secret");
+                            $this->storeToCache($key, $secret);
+                        }
                     }
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -113,9 +113,12 @@ protected function getVariables()`
`113`	`113`	`'SecretId' => $item['ARN'],`
`114`	`114`	`]);`
`115`	`115`
`116`		`- foreach (json_decode($result['SecretString'], true) as $key => $secret) {`
`117`		`- putenv("$key=$secret");`
`118`		`- $this->storeToCache($key, $secret);`
	`116`	`+ $secretValues = json_decode($result['SecretString'], true);`
	`117`	`+ if (is_array($secretValues)) {`
	`118`	`+ foreach ($secretValues as $key => $secret) {`
	`119`	`+ putenv("$key=$secret");`
	`120`	`+ $this->storeToCache($key, $secret);`
	`121`	`+ }`
`119`	`122`	`}`
`120`	`123`	`}`
`121`	`124`	`}`