bugfix: fix CI errors

Author: taylorcyang

.github/workflows/coverage.yml

@@ -13,15 +13,14 @@ on:
 jobs:
   coverage-ubuntu-gcc:
     timeout-minutes: 30
-    # JavaScriptCore requires libicu66 which is only avaliable on ubuntu-20.04
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
         backends: [ V8, JavaScriptCore, QuickJs, Lua ]
     steps:
       - uses: actions/checkout@v4.1.7
-      - uses: actions/cache@v4.0.2
+      - uses: actions/cache@v4
         with:
           key: ScriptX-UnitTests-Depedencies-${{ hashFiles('test/cmake/**') }}
           path: |

.github/workflows/unit_tests.yml

@@ -25,7 +25,7 @@ jobs:
           # - Release
     steps:
       - uses: actions/checkout@v4.1.7
-      - uses: actions/cache@v4.0.2
+      - uses: actions/cache@v4
         with:
           key: ScriptX-UnitTests-Depedencies-${{ hashFiles('test/cmake/**') }}
           path: |
@@ -62,7 +62,7 @@ jobs:
           - Release
     steps:
       - uses: actions/checkout@v4.1.7
-      - uses: actions/cache@v4.0.2
+      - uses: actions/cache@v4
         with:
           key: ScriptX-UnitTests-Depedencies-${{ hashFiles('test/cmake/**') }}
           path: |
@@ -102,8 +102,7 @@ jobs:
 
   ubuntu-gcc-run:
     timeout-minutes: 30
-    # JavaScriptCore requires libicu66 which is only avaliable on ubuntu-20.04
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
@@ -113,7 +112,7 @@ jobs:
           - Release
     steps:
       - uses: actions/checkout@v4.1.7
-      - uses: actions/cache@v4.0.2
+      - uses: actions/cache@v4
         with:
           key: ScriptX-UnitTests-Depedencies-${{ hashFiles('test/cmake/**') }}
           path: |
@@ -140,15 +139,15 @@ jobs:
 
   ubuntu-v8-versions-build:
     timeout-minutes: 60
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
         # format index{0 .. index-1}/concurrency
         job_split: [ 0/8, 1/8, 2/8, 3/8, 4/8, 5/8, 6/8, 7/8 ]
     steps:
       - uses: actions/checkout@v4.1.7
-      - uses: actions/cache@v4.0.2
+      - uses: actions/cache@v4
         with:
           key: ScriptX-UnitTests-Depedencies-${{ hashFiles('test/cmake/**') }}
           path: |
@@ -177,7 +176,7 @@ jobs:
           - Release
     steps:
       - uses: actions/checkout@v4.1.7
-      - uses: actions/cache@v4.0.2
+      - uses: actions/cache@v4
         with:
           key: ScriptX-UnitTests-Depedencies-${{ hashFiles('test/cmake/**') }}
           path: |
@@ -206,7 +205,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [ 14.x, 15.x, 16.x, 18.x ] # 19.x
+        node-version: [ 18.x, 20.x, 22.x ] # 24.x
     steps:
       - uses: actions/checkout@v4.1.7
       - name: Use Node.js ${{ matrix.node-version }}
@@ -233,7 +232,7 @@ jobs:
         emscripten-version: [ '4.0.0', '3.1.33' ]
     steps:
       - uses: actions/checkout@v4.1.7
-      - uses: actions/cache@v4.0.2
+      - uses: actions/cache@v4
         with:
           key: ScriptX-UnitTests-Depedencies-${{ hashFiles('test/cmake/**') }}
           path: |
@@ -264,5 +263,4 @@ jobs:
         run: |
           cd build
           # exclude failed tests
-          # --no-experimental-fetch config from https://github.com/emscripten-core/emscripten/issues/16915
-          node --no-experimental-fetch UnitTests.js '--gtest_filter=-ThreadPool.*:EngineScopeTest.ExitEngine:EngineScopeTest.TwoThreads:EngineScopeTest.ThreadLocal:MessageQueue.Interrupt:MessageQueue.Shutdown:MessageQueue.ShutdownNow:MessageQueue.FullAndPostInsideLoopQueue:ReferenceTest.WeakGc:ReferenceTest.WeakGc:ReferenceTest.GlobalNotClear:ReferenceTest.GlobalOnEngineDestroy:ReferenceTest.WeakOnEngineDestroy:ReferenceTest.WeakNotClrear:ManagedObjectTest.EngineDispose:ManagedObjectTest.FunctionCallback:PressureTest.All:EngineTest.JsPromiseTest:EngineTest.JsPromiseTest2:ShowCaseTest.SetTimeout'
+          node UnitTests.js '--gtest_filter=-ThreadPool.*:EngineScopeTest.ExitEngine:EngineScopeTest.TwoThreads:EngineScopeTest.ThreadLocal:MessageQueue.Interrupt:MessageQueue.Shutdown:MessageQueue.ShutdownNow:MessageQueue.FullAndPostInsideLoopQueue:ReferenceTest.WeakGc:ReferenceTest.WeakGc:ReferenceTest.GlobalNotClear:ReferenceTest.GlobalOnEngineDestroy:ReferenceTest.WeakOnEngineDestroy:ReferenceTest.WeakNotClrear:ManagedObjectTest.EngineDispose:ManagedObjectTest.FunctionCallback:PressureTest.All:EngineTest.JsPromiseTest:EngineTest.JsPromiseTest2:ShowCaseTest.SetTimeout'

backend/JavaScriptCore/JscEngine.cc

@@ -28,8 +28,10 @@ JSClassRef JscEngine::externalClass_{};
 
 // When we link against high-version library
 // but run with a low-version one, macOS/iOS linker just set the undefined symbols to nullptr.
-// cast to void* to suppress g++ -Werror=address
+// suppress g++ -Werror=address
+SCRIPTX_BEGIN_INCLUDE_LIBRARY
 bool JscEngine::hasByteBufferAPI_ = reinterpret_cast<void*>(&JSValueGetTypedArrayType) != nullptr;
+SCRIPTX_END_INCLUDE_LIBRARY
 
 JscEngine::JscEngine(std::shared_ptr<utils::MessageQueue> mq)
     : messageQueue_(mq ? std::move(mq) : std::make_shared<utils::MessageQueue>()) {

src/utils/MessageQueue.h

@@ -25,6 +25,7 @@
 #include <functional>
 #include <limits>
 #include <mutex>
+#include <stdexcept>
 #include <vector>
 #include "../foundation.h"
 #include "MemoryPool.hpp"

test/src/NativeTest.cc

@@ -860,7 +860,7 @@ TEST_F(NativeTest, MissMatchedType) {
 
   EngineScope scope(engine);
 
-  auto def = defineClass<Instance>("Instance")
+  static auto def = defineClass<Instance>("Instance")
                  .constructor()
                  .function("sfun", &Instance::sfun)
                  .instanceFunction("fun", &Instance::fun)

test/src/ThreadPoolTest.cc

@@ -17,6 +17,7 @@
 
 #include <array>
 #include <atomic>
+#include <chrono>
 #include <cmath>
 #include <iomanip>
 #include "test.h"

test/src/ValueTest.cc

@@ -557,7 +557,7 @@ void testNumber(T value) {
   EXPECT_EQ(num.toInt64(), static_cast<int64_t>(value));
 #endif
   EXPECT_FLOAT_EQ(num.toFloat(), static_cast<float>(value));
-  EXPECT_FLOAT_EQ(num.toDouble(), static_cast<double>(value));
+  EXPECT_DOUBLE_EQ(num.toDouble(), static_cast<double>(value));
 }
 
 TEST_F(ValueTest, Number) {